Different languages subs are downloaded with the same name

Bug #1076336 reported by Shoham Peller
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
SubDownloader
Triaged
Low
Shoham Peller

Bug Description

SubDownloader 2.0.14

When the user downloads a couple of subtitles files for the same video, because they are in different languages or for any other reason, subDownlaoder downloads them with the same name, hence failing and asking user to replace the previously downloaded file, or to pick a new name for the new file.

This can easily be fixed by writing some file-name-generating code.
Possible solutions are to name files:
<video-name>.<LANGUAGE>.srt
or:
<video-name>.<COUNTER_NUMBER>.srt

Changed in subdownloader:
status: New → Triaged
Revision history for this message
Shoham Peller (shoham-peller) wrote :

Well , digging through the code a bit, I've seen that the program's settings allow to add the language or the uploader to the filename. That solves it. Could have been smarter to check the settings before :\

I still think it can be done better, by never overwriting, but to append a counter to the filename in case the file exists. That's what the video player BSPlayer does. I'll make the neccessary changes in my branch:
https://code.launchpad.net/~shoham-peller/subdownloader/filename-gererator

Revision history for this message
Alessandro Losavio (alo21) wrote :

Thanks! Your contribution is really appreciated.

Changed in subdownloader:
assignee: nobody → Shoham Peller (shoham-peller)
importance: Undecided → Wishlist
importance: Wishlist → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.