This results in an email sent to all admins saying that the notification failed.
The admin with digest on will not receive the empty message, but those without digest will.
Reason is because it tries to store the data in a temporary table to digest them all.
A couple of solutions:
- take off the non null constraint on the temporary table (will fix similar issues if any)
- set the message to be required (won't fix similar issues if any)
If we do the second option, we should have a hunt around other notification types to see if they can have null message and fix them as well
Subject: User notification error was probably caused by your server
configuration.
exception 'SQLException' with message 'Failed to get a recordset: postgres7
error: [-1: ERROR: null value in column "message" violates not-null
constraint] in adodb_throw(INSERT INTO "notification_emaildigest_queue"
("type", "usr", "ctime", "url") VALUES (?, ?, ?, ?), Array)
Command was: INSERT INTO "notification_emaildigest_queue" ("type", "usr",
"ctime", "url") VALUES (?, ?, ?, ?) and values was (7,2,2012-10-23
15:41:44,view/artefact.php?artefact=1458781&view=219885)' in
/var/www/lib/dml.php:1060
Stack trace:
#0
/var/www/notification/emaildigest/lib.php(44):
insert_record('notification_em...', Object(stdClass))
#1 [internal function]:
PluginNotificationEmaildigest::notify_user(Object(stdClass), Object(stdClass))
#2
/var/www/lib/mahara.php(1359):
call_user_func_array(Array, Array)
#3
/var/www/lib/activity.php(468):
call_static_method('PluginNotificat...', 'notify_user', Object(stdClass),
Object(stdClass))
#4
/var/www/lib/activity.php(507):
ActivityType->notify_user(Object(stdClass))
#5
/var/www/lib/activity.php(82):
ActivityType->notify_users()
#6
/var/www/lib/activity.php(219):
handle_activity('7', Object(stdClass), true)
#7
/var/www/lib/cron.php(158):
activity_process_queue()
#8 {main}
This is related to the Alfred Health bug - WR215749.
Applying the same fix plus making the message mandatory for objectionalble content.