Tenant quota usage doesn't check if volume service is enabled

Bug #1075319 reported by Gabriel Hurley
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Tihomir Trifonov

Bug Description

This line checks for a quota from a volume service even if it's not enabled:

https://github.com/openstack/horizon/blob/master/openstack_dashboard/usage/quotas.py#L85

That needs to be wrapped with a call to is_service_enabled and the display mechanism needs to adapt if the quota doesn't exist.

Revision history for this message
Roberto Bouza (bouzafr) wrote :

Also I think this guy needs to be updated:

openstack_dashboard/api/base.py

On the call to (def url_for):

service = get_service_from_catalog(catalog, service_type)
...

up to end of the file. It needs to be enclosed within a:

if is_service_enabled(request, service_type)

Hope that helps.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/15722

Changed in horizon:
assignee: nobody → Tihomir Trifonov (ttrifonov)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/15722
Committed: http://github.com/openstack/horizon/commit/4c88b9b5977c50525771876b2a8624fa586b8f6e
Submitter: Jenkins
Branch: master

commit 4c88b9b5977c50525771876b2a8624fa586b8f6e
Author: Tihomir Trifonov <email address hidden>
Date: Fri Nov 9 14:55:23 2012 +0200

    Added a check for volume service in quota functions

    When displaying the quotas, we have to check if
    volume service is present in the service catalog.
    If not - then to remove the volume quotas from
    the result object.

    Fixes bug 1075319

    Change-Id: Icd049a5b147cac039add1570a166d775fd0d6ec4

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.