[12.10.4] display "ac adapter" label instead of icon

[Sebastien Bacher]

Using 12.10.4 with a docked laptop my panel displays an "ac adapter" label next to a charging icon, before that update it used to display a battery with the charging sign on it

[Lars Karlitski (larsu)]

The label's text is set to the device name in device.c:610. Maybe due to a side-effect of [1], the label is visible if an icon is not available?

[1] https://code.launchpad.net/~charlesk/indicator-power/lp-1066208/+merge/131547

[Charles Kerr (charlesk)]

seb128, could you paste the output of "$ upower --dump" when this is happening?

[Sebastien Bacher (seb128)]

Device: /org/freedesktop/UPower/devices/line_power_AC
  native-path: /sys/devices/LNXSYSTM:00/device:00/ACPI0003:00/power_supply/AC
  power supply: yes
  updated: Tue Nov 6 10:02:47 2012 (1789 seconds ago)
  has history: no
  has statistics: no
  line-power
    online: yes

Device: /org/freedesktop/UPower/devices/battery_BAT0
  native-path: /sys/devices/LNXSYSTM:00/device:00/PNP0C0A:00/power_supply/BAT0
  vendor: Samsung SDI
  model: DELL C207206
  serial: 25460
  power supply: yes
  updated: Tue Nov 6 10:02:52 2012 (1784 seconds ago)
  has history: yes
  has statistics: yes
  battery
    present: yes
    rechargeable: yes
    state: fully-charged
    energy: 94.5 Wh
    energy-empty: 0 Wh
    energy-full: 94.5 Wh
    energy-full-design: 94.5 Wh
    energy-rate: 0.01125 W
    voltage: 12.798 V
    percentage: 100%
    capacity: 83.4881%
    technology: lithium-ion

Daemon:
  daemon-version: 0.9.17
  can-suspend: yes
  can-hibernate no
  on-battery: no
  on-low-battery: no
  lid-is-closed: yes
  lid-is-present: yes
  is-docked: no

[Charles Kerr (charlesk)]

What's causing this bug:

Before 12.10, indicator-power only showed batteries in the panel. The new i-power code shows other devices too as per the Power Menu spec <https://wiki.ubuntu.com/Power#Battery_menu> (which, has an example of showing a mouse in the panel). The new code picks the device based on the spec's rule: "which will lose power soonest (and optionally when), or otherwise which device will take longest to charge (and optionally how long it will take)."

This bug is happening because the above criteria gives the same weight to (1) an AC Power Line and (2) a battery or mouse or keyboard which is neither charging nor discharging.

So we need to refine the choice for the case where no device is charging nor discharging. I suggest i-power picks a battery first, if there is one. Otherwise, other devices like mouse/keyboard/ups. The power line device would be chosen last.

[Launchpad Janitor (janitor)]

This bug was fixed in the package indicator-power - 12.10.5-0ubuntu1

---------------
indicator-power (12.10.5-0ubuntu1) raring; urgency=low

  * New upstream release:
    - Fix a device display bug introduced in 12.10.3 (LP: #1075192)
 -- Sebastien Bacher <email address hidden> Wed, 14 Nov 2012 11:09:59 +0100