I18N issue: some log/messages are not wrapped with _()

Bug #1075088 reported by Ying Chun Guo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Ying Chun Guo
Grizzly
Fix Released
Low
Ying Chun Guo

Bug Description

Hi, all

In glance source code, some LOG messages or printing messages are wrapped with _(), some are not. I used a program to scan all the source code, and saved all the LOG messages and printing messages without _() into a file.

We need to fix this small but important issue, to make our codes look better.

Daisy

Revision history for this message
Ying Chun Guo (daisy-ycguo) wrote :
Changed in glance:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Ying Chun Guo (daisy-ycguo) wrote :

Hi,

May I work on this issue, cause it is required by my customers?

Daisy

Changed in glance:
assignee: nobody → Ying Chun Guo (daisy-ycguo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/16611

Changed in glance:
status: Triaged → In Progress
Brian Waldon (bcwaldon)
Changed in glance:
milestone: none → grizzly-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/16611
Committed: http://github.com/openstack/glance/commit/45f41ffc9baa3688fc2bb4c80da308a1aecd941d
Submitter: Jenkins
Branch: master

commit 45f41ffc9baa3688fc2bb4c80da308a1aecd941d
Author: daisy-ycguo <email address hidden>
Date: Wed Nov 21 15:40:26 2012 +0800

    Wrap log messages with _()

    Bug 1075088

    There are a few log messages without _(), but a lot messages with _().
    Wrap these log messages with _() in order to make the code consistent.

    Change-Id: I8f3c66c23c7e42d7b4ede11c26d5f9c96c39be73

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.