I18N issue: some log messages are not wrapped with _()

Bug #1075082 reported by Ying Chun Guo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Ying Chun Guo

Bug Description

Hi, all

In nova source code, some LOG messages are wrapped with _(), some are not. I used a program to scan all the source code, and recorded all the LOG messages without _() in a file.

We need to fix this small but important issue, to make our codes professional.

Daisy

Tags: i18n
Revision history for this message
Ying Chun Guo (daisy-ycguo) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/15394

Changed in nova:
assignee: nobody → Davanum Srinivas (dims-v)
status: New → In Progress
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :
Changed in nova:
assignee: Davanum Srinivas (dims-v) → nobody
Changed in nova:
assignee: nobody → Ying Chun Guo (daisy-ycguo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/16414

Revision history for this message
Ying Chun Guo (daisy-ycguo) wrote :

Nova has around 2000 messages wrapped with _() and around 20 messages without _(). I will suggest we change the remained messages in order to make them consistent.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/16565

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/16414
Committed: http://github.com/openstack/nova/commit/296403319182a62c737363872f9e57d56bc2669d
Submitter: Jenkins
Branch: master

commit 296403319182a62c737363872f9e57d56bc2669d
Author: daisy-ycguo <email address hidden>
Date: Mon Nov 19 14:07:16 2012 +0800

    Wrap log messages with _()

    bug 1075082

    There are a few log messages without _(), but a lot messages with _().
    Wrap these log messages with _() in order to make the code consistent.

    Change-Id: Ibaff2c352df925f7e00d5a62d111ef73f60c944b

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.