Don't use geoclue if "show-auto-detected-location" is set to false
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Indicator Date and Time |
Fix Released
|
Medium
|
Charles Kerr | ||
indicator-datetime (Ubuntu) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
This bug is split off from an "umbrella" Bug #944251 which discusses various network connections made by various applications.
There are two reasons to not use geoclue until the user's specified it in the "show-auto-
(1) In the Nov 2012 UDS session on eliminating unnecessary startup memory/performance hits on the Nexus 7, we discussed deferring indicator-
(2) Several users perceive datetime's use of geoclue/geoip as a breach of privacy. (See bug #944251, http://
Inspecting the code though, it seems that the geoclue code all boils down to setting the "geo_timezone" variable for use in update_
So, indicator-datetime could avoid unnecessary startup overhead -- and please privacy-minded users -- by deferring use of geoclue until/unless the user enables the "In the clock's menu, show time in the auto-detected location" checkbox.
Related branches
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Lars Karlitski (community): Approve
-
Diff: 303 lines (+89/-87)1 file modifiedsrc/datetime-service.c (+89/-87)
- Charles Kerr (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 15 lines (+6/-0)1 file modifieddebian/changelog (+6/-0)
summary: |
- Don't ping geoclue server if show-auto-detected-location is false + Don't use geoclue if show-auto-detected-location is false |
summary: |
- Don't use geoclue if show-auto-detected-location is false + Don't use geoclue if "show-auto-detected-location" is set to false |
Changed in indicator-datetime: | |
status: | Triaged → In Progress |
description: | updated |
description: | updated |
description: | updated |
Changed in indicator-datetime: | |
status: | In Progress → Fix Committed |
tags: | added: mobile |
tags: | added: nexus7 |
no longer affects: | ubuntu-nexus7 |
Changed in indicator-datetime (Ubuntu): | |
status: | New → Fix Committed |
status: | Fix Committed → Confirmed |
importance: | Undecided → Medium |
Changed in indicator-datetime: | |
status: | Fix Committed → Fix Released |
After starting a Unity session with lp:~charlesk/indicator-datetime/lp-1074999 and "Time & Date Settings > Clock > Show Time in auto-detected location" set to false (which is the default value):
> $ ps -ef | grep geo
> charles 30147 8553 0 19:05 tty2 00:00:00 grep --color=auto geo
Then after setting autodetect to true and restarting Unity:
> $ ps -ef | grep geo geoclue/ geoclue- master ubuntu- geoip/ubuntu- geoip-provider
> charles 30255 1 0 19:05 ? 00:00:00 /usr/lib/
> charles 30271 1 0 19:05 ? 00:00:00 /usr/lib/
> charles 30549 8553 0 19:05 tty2 00:00:00 grep --color=auto geo