BridgeInterfaceDriver should set macaddress for dhcp_veth

[Nachi Ueno]

BridgeInterfaceDriver should set macaddress for dhcp_veth

Current code set macaddress for root_veth. So mac address looks different from inside of namespace.
Also, This is not consistent with another bridge driver.

[dan wendlandt (danwent)]

does the mac address of a veth matter? I would have thought it would be the mac address of the tap device that dnsmasq listens on that matters.

[Akihiro Motoki (amotoki)]

I think the bug is valid.

This problem is specific to BridgeInterfaceDrive.
root_veth (one peer of veth) is connected to a linux bridge and dhcp_veth (the other peer of veth) is moved to a namespace.

Since dnsmasq refers the peer of veth in a namespace, the mac address of dhcp_veth should be set.
But in the current code, the mac addresss of the port is set to root_veth and it is not referred from anywhere.

[dan wendlandt (danwent)]

ah, i see, I was thinking about the hybrid driver, in which case the veth interface is not the one with the IP address on it. this makes sense.

[Nachi Ueno (nati-ueno)]

Hi Akihiro, Dan

Thank Akihiro for detailed explanation.
Dan could you set this bug as valid?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/15966

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/15966
Committed: http://github.com/openstack/quantum/commit/e09051b31fb33707bebf88e4577dcda06f6eeffb
Submitter: Jenkins
Branch: master

commit e09051b31fb33707bebf88e4577dcda06f6eeffb
Author: Akihiro MOTOKI <email address hidden>
Date: Tue Nov 13 20:36:09 2012 +0900

    Ensure that mac address is set to namespace side veth end.

    Fixes bug 1073350

    Change-Id: I4c0e85b500ac966a4250e2b6df634aab812f67e9