Nova virt driver interface lacks post_live_migration_at_destination()

[Dan Smith]

The libvirt, xenapi, and hyperv drivers define it, and the manager uses it, but it's not in the ComputeDriver base class:

https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2613
https://github.com/openstack/nova/blob/master/nova/virt/xenapi/driver.py#L508
https://github.com/openstack/nova/blob/master/nova/virt/hyperv/driver.py#L172
https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2408

[Davanum Srinivas (DIMS) (dims-v)]

pre_live_migration is missing too?

[Davanum Srinivas (DIMS) (dims-v)]

base baremetal hyper-v libvirt xenapi method
yes yes yes yes yes live_migration
yes no yes yes yes confirm_migration
yes no yes yes yes finish_migration
yes no yes yes yes finish_revert_migration
no no yes yes yes post_live_migration_at_destination
no no yes yes yes pre_live_migration
no no no yes yes pre_block_migration

[Dan Smith (danms)]

It's fine for the drivers to leave something unimplemented, but not for base to omit it. So, it looks like the following need to be added to base:

post_live_migration_at_destination, pre_live_migration, pre_block_migration

I'll submit a patch for this soon.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/14894

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/14894
Committed: http://github.com/openstack/nova/commit/e23b3fbac5097cc71e6b23f535598d861e995dfa
Submitter: Jenkins
Branch: master

commit e23b3fbac5097cc71e6b23f535598d861e995dfa
Author: Dan Smith <email address hidden>
Date: Fri Oct 26 09:00:38 2012 -0700

    Add missing live migration methods to ComputeDriver base class

    Several live migration-related methods are implemented in the virt
    drivers (and used in compute/manager), but missing from the base
    class:

      pre_live_migration()
      pre_block_migration()
      post_live_migration_at_destination()

    This adds those, fixing bug 1071404.

    Change-Id: Iccca4706462c5452882e34608df6e477d2280099