The wrong note in swift/common/ring/utils.py

Bug #1070621 reported by zhoubing
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Fix Released
Undecided
Kun Huang

Bug Description

In swift/common/ring/utils.p

in build_tier_tree():

in Example

The tier tree would look like:

(2,): [(1, 192.168.2.1:6000),
           (1, 192.168.2.2:6000)],

i think it should be

(2,): [(2, 192.168.2.1:6000),
           (2, 192.168.2.2:6000)],

zhoubing (zhoubing00)
Changed in swift:
assignee: nobody → zhoubing (zhoubing00)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/22855

Changed in swift:
assignee: zhoubing (zhoubing00) → Kun Huang (academicgareth)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.openstack.org/22855
Committed: http://github.com/openstack/swift/commit/d9130d79e5fbabef4622dc97a8832e6f83bc3522
Submitter: Jenkins
Branch: master

commit d9130d79e5fbabef4622dc97a8832e6f83bc3522
Author: Kun Huang <email address hidden>
Date: Mon Feb 25 22:52:39 2013 +0800

    Correct docstring for swift.common.ring.utils.build_tier_tree and add
    unit test for it.

    Some mistakes is in original docstring of that method. There's no unit
    test for two methods in swift.common.ring.utils.

    Fixes: bug #1070621

    Change-Id: I6f4f211ea67d7fb8ccfe659f30bb0f5d394aca6b

Changed in swift:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in swift:
milestone: none → 1.8.0-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in swift:
milestone: 1.8.0-rc1 → 1.8.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.