Wrong unit test logic when we check the scheduler Diskfilter
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Andrea Rosa |
Bug Description
The unit test "test_disk_
I think it's supposed to test a failure in the host_passes check but as is it is not working.
We need to create and 'insance_type' which requires a disk that exceeds the disk availability in the host:
@@ -556,14 +556,14 @@ class HostFiltersTest
filt_cls = self.class_
- filter_properties = {'instance_type': {'root_gb': 2,
+ filter_properties = {'instance_type': {'root_gb': 11,
service = {'disabled': False}
host = fakes.FakeHostS
- self.assertTrue
+ self.assertFals
Changed in nova: | |
status: | Opinion → In Progress |
tags: | added: low-hanging-fruit |
Changed in nova: | |
milestone: | none → grizzly-1 |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | grizzly-1 → 2013.1 |
As reported in the comment I have the code change ready for that