Wrong unit test logic when we check the scheduler Diskfilter

[Andrea Rosa]

The unit test "test_disk_filter_fails" for testing the scheuler disk filter has a wrong logic.
I think it's supposed to test a failure in the host_passes check but as is it is not working.
We need to create and 'insance_type' which requires a disk that exceeds the disk availability in the host:

@@ -556,14 +556,14 @@ class HostFiltersTestCase(test.TestCase):
         self._stub_service_is_up(True)
         filt_cls = self.class_map['DiskFilter']()
         self.flags(disk_allocation_ratio=1.0)
- filter_properties = {'instance_type': {'root_gb': 2,
+ filter_properties = {'instance_type': {'root_gb': 11,
                                                'ephemeral_gb': 1}}
         capabilities = {'enabled': True}
         service = {'disabled': False}
         host = fakes.FakeHostState('host1', 'compute',
                 {'free_disk_mb': 11 * 1024, 'total_usable_disk_gb': 13,
                  'capabilities': capabilities, 'service': service})
- self.assertTrue(filt_cls.host_passes(host, filter_properties))
+ self.assertFalse(filt_cls.host_passes(host, filter_properties))

[Andrea Rosa (andrea-rosa-m)]

As reported in the comment I have the code change ready for that

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/14669

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/14669
Committed: http://github.com/openstack/nova/commit/9ec1f131822a8ba1b849732bcde001d228c7e98e
Submitter: Jenkins
Branch: master

commit 9ec1f131822a8ba1b849732bcde001d228c7e98e
Author: Andrea Rosa <email address hidden>
Date: Tue Oct 23 11:58:16 2012 +0100

    Fix bug in a test for the scheduler DiskFilter.

    There is an error in the logic for a unit test in the Scheduler DiskFilter.
    We need to test the failure of the host_passes check with the
    "test_disk_filter_fails" test.

    Fixes bug 1070264.

    Change-Id: Ib07f47b74a6634c573dca8fb4efa2d95b2e1ed87