run_tests.sh usage message and behavior for -x don't match

Bug #1070047 reported by Eric Harney
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Rushi Agrawal

Bug Description

run_tests.sh's usage message says that -x is to "Stop running tests after the first error" but it actually is translated to --coverage-xml. Either need to update the message or continue passing -x to nose.

Eric Harney (eharney)
Changed in cinder:
assignee: nobody → Eric Harney (eharney)
Revision history for this message
Rushi Agrawal (rushiagr) wrote :

This commit
https://github.com/openstack/cinder/commit/50792c2ff41fdc7e73b3e3c51f4510366debfd14
shows that the committer wanted to introduce an option for XML coverage report, but unknowingly overrode the default option for nose tests: -x.

Changed in cinder:
assignee: Eric Harney (eharney) → Rushi Agrawal (rushiagr)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/15630

Changed in cinder:
status: New → In Progress
Revision history for this message
Rushi Agrawal (rushiagr) wrote :

The same bug can exist in other OpenStack projects too.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/15630
Committed: http://github.com/openstack/cinder/commit/eedc857008a122ee38661581f27f102de52a4886
Submitter: Jenkins
Branch: master

commit eedc857008a122ee38661581f27f102de52a4886
Author: Rushi Agrawal <email address hidden>
Date: Sat Nov 3 12:21:28 2012 +0530

    Fix run_tests.sh ambiguous usage msg and behaviour for -x option

    In commit
    https://github.com/openstack/cinder/commit/
    50792c2ff41fdc7e73b3e3c51f4510366debfd14,
    the committer wanted to add an option in run_tests.sh for generating XML
    coverage report, but ended up accidentally overriding the default nose
    option -x. But, the usage message still showed that using option -x will
    'Stop running tests after the first error or failure'. So, I changed the
    option to generate XML report to -X (capitalized 'x'). So now both -x and
    -X options are available, with different purposes.

    Fixes bug 1070047

    Change-Id: Ie8c30c14629d4811d6db74f3eea9cdecb1d27c8a

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.