Horizon volume without a name displays id on first load, and blank on ajax pull

Bug #1070042 reported by Jake Dahn
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Victoria Martinez de la Cruz

Bug Description

When you create a volume from the cli without a name, you will experience teh following behavior in the volume list table.

The name column will display the volume id on the first load, and when it does an ajax poll it will refresh to the actual value of None

Changed in horizon:
status: New → Confirmed
Revision history for this message
Tihomir Trifonov (ttrifonov) wrote :

Reason:

IndexView perforrms some data manipulation on the volumes:

    def get_data(self):
        volumes = self._get_volumes()
        instances = self._get_instances()
        self._set_id_if_nameless(volumes, instances)
        self._set_attachments_string(volumes, instances)
        return volumes

while for the ajax updated rows, the get_data is called from:

    class UpdateRow(tables.Row):
        ajax = True

        def get_data(self, request, volume_id):
            volume = api.volume_get(request, volume_id)
            return volume

which doesn't substitute the display_name with id (_set_id_if_nameless is not called).

Changed in horizon:
assignee: nobody → Victoria Martínez de la Cruz (vickymsee)
Revision history for this message
Victoria Martinez de la Cruz (vkmc) wrote :

How about the notification popup? Should it also display the Volume's ID?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/19216

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/19216
Committed: http://github.com/openstack/horizon/commit/158ce5ca268ab2824c777c14120009641be47ae4
Submitter: Jenkins
Branch: master

commit 158ce5ca268ab2824c777c14120009641be47ae4
Author: Victoria Martínez de la Cruz <email address hidden>
Date: Tue Jan 8 13:44:37 2013 -0300

    Check the display name for volumes on AJAX polls.

    If a volume is created from the CLI without a name,
    its displayed name on the Dashboard will be its id.

    Change-Id: I806df643d7a2e0e93db673ea9718fe30927d930e
    Implements: Display name check for unnamed volumes
    Fixes: bug #1070042

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → Medium
milestone: none → grizzly-3
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.