[6.1/firefox] Editable list: self.edition_form is undefined when switching from a line to another

[Guewen Baconnier @ Camptocamp]

Hi,

Using Firefox 16.01 (last stable version) with OpenERP 6.1, on runbot.

On an editable list view, when we switch from a line to another, sometimes happens a "self.edition_form is undefined" exception.
It also happens that a line entirely disappear.

I couldn't reproduce it on chrome, but it is easily reproducible on Firefox (seems to happen more often when we change rapidly from a line to another.

I'll attach a screencast.

Have a nice day

Guewen

[Mohammed Shekha(Open ERP) (msh-openerp)]

Hello,

The fix has been landed in lp:~openerp-dev/openerp-web/6.1-opw-580541-msh.

Thanks.

[Kyle Waid (midwest)]

Hello,

I have tested this fix. I still have the same issue

[Antoine André (antoine-andre1986)]

I confirm that i still have this issue too...

[Yann Papouin (yann-papouin)]

Really easy to reproduce on every editable tree where you can switch from list to form:

- Start to edit one line
- Click on the "Form" button
==> Uncaught TypeError: Cannot call method 'stop' of undefined

On latest 6.1 stable branch, with Firefox 18 and Chrome 24

But actually the proposed fix is at least fixing this case. So maybe more occurrence of this bug exists.

[Yann Papouin (yann-papouin)]

I've just added a check before to avoid this window to popup:

if (typeof self.edition_form != 'undefined') {

}

[Yann Papouin (yann-papouin)]

=== modified file addons/web/static/src/js/view_list_editable.js
--- addons/web/static/src/js/view_list_editable.js 2012-06-15 05:54:40 +0000
+++ addons/web/static/src/js/view_list_editable.js 2013-01-23 08:39:53 +0000
@@ -136,9 +136,15 @@
             }
             cancelled.then(function () {
                 self.view.unpad_columns();
- self.edition_form.stop();
- self.edition_form.$element.remove();
- delete self.edition_form;
+ if(typeof self.edition_form != 'undefined')
+ {
+ // Fix for bug #1066703: self.edition_form is undefined when switching from a line to another
+ if(self.edition_form){
+ self.edition_form.stop();
+ self.edition_form.$element.remove();
+ delete self.edition_form;
+ }
+ }
                 self.dataset.index = null;
                 delete self.edition_id;
                 delete self.edition;

[Stefan Rijnhart (Opener) (stefan-opener)]

Thank you Yann Papouin for the patch, I am proposing it to ocb-web/6.1