lockutils - remove lock dir creation and cleanup
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
Undecided
|
Ben Nemec | ||
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Ben Nemec | ||
neutron |
Fix Released
|
Undecided
|
Ann Taraday | ||
oslo-incubator |
Fix Released
|
High
|
Ben Nemec |
Bug Description
See https:/
This:
Why are we deleting the lock dir here? Does that even work? i.e. what if someone concurrently tries to take the lock, re-creates the dir and lock a new file?
affects: | openstack-common → oslo |
Changed in oslo: | |
assignee: | nobody → Ben Nemec (bnemec) |
status: | Confirmed → In Progress |
Changed in nova: | |
assignee: | nobody → Ben Nemec (bnemec) |
status: | New → In Progress |
Changed in nova: | |
milestone: | none → havana-3 |
status: | Fix Committed → Fix Released |
Changed in oslo: | |
milestone: | none → havana-3 |
status: | Fix Committed → Fix Released |
Changed in oslo: | |
milestone: | havana-3 → 2013.2 |
Changed in nova: | |
milestone: | havana-3 → 2013.2 |
Changed in neutron: | |
status: | New → Confirmed |
Changed in neutron: | |
assignee: | nobody → Ann Kamyshnikova (akamyshnikova) |
status: | Confirmed → In Progress |
Changed in neutron: | |
milestone: | none → icehouse-2 |
status: | Fix Committed → Fix Released |
Changed in neutron: | |
milestone: | icehouse-2 → 2014.1 |
Ok, this reared its head in the form of bug #1158179
I think we need to move the lock_path directory creation and removal code out of this function altogether and require the callers to do it
Using a tempdir just never makes sense
For a well known path, if this code assumes the responsibility of creating the dir, it should also remove the dir ... but the bug shows that it's not safe to do so