debuild ignores dpkg-genchanges hook

Bug #1065201 reported by Maciej Malycha
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
devscripts (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

The hook dpkg-genchanges described in man is ignored by debuild - both when specified as command line option --dpkg-genchanges-hook and configuration option DEBUILD_DPKG_GENCHANGES_HOOK. All the logic seems to be in place, only the code reading hook value is missing. I found it in Debian, devscripts-2.10.66, but exists also in development. Attached patch fixes the problem in revision 126 of lp:ubuntu/devscripts branch.

Tags: patch
Revision history for this message
Maciej Malycha (m-malycha) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "debuild_patch.diff" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Revision history for this message
Benjamin Drung (bdrung) wrote :

Thanks for your patch. It's applied in our git repository [1] and will be part of the next upload.

[1] http://anonscm.debian.org/gitweb/?p=devscripts/devscripts.git;a=commitdiff;h=da45213e

Changed in devscripts (Ubuntu):
status: New → Fix Committed
importance: Undecided → Wishlist
importance: Wishlist → Low
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package devscripts - 2.12.5

---------------
devscripts (2.12.5) unstable; urgency=low

  [ James McCoy ]
  * bts:
    + Provide a clearer error message when Authen::SASL isn't installed.
      (Closes: #689816)
    + Don't require a usertag after 'bts usertag <bug> ='. (Closes: #689815)
    + Don't require a package after 'bts affects <bug> ='. (Closes: #690131)
  * Add German translation of man pages. Thanks to Chris Leick. (Closes:
    #687985)

  [ Benjamin Drung ]
  * Fix Subversion typo and write all instances of it with an capital initial
    letter. Thanks to Regid Ichira for the finding. (Closes: #689953)
  * debuild:
    - Fix failure if called with --preserve-env and GREP_OPTIONS is set.
      Thanks to Aaron Culich for the patch. (Closes: #501056, LP: #581319)
    - Add missing bits to support dpkg-genchanges hook.
      Thanks to Maciej Malycha for the patch. (LP: #1065201)
  * wrap-and-sort: Sort Pre-Depends list (LP: #1070599)

  [ David Prévot ]
  * French translation update.

 -- Benjamin Drung <email address hidden> Wed, 24 Oct 2012 22:15:34 +0200

Changed in devscripts (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.