Unity menubar crashes when activating a submenu in LibreOffice while using Orca screen reader

[Antonio Fernández]

Impact:

Fixes segfault on using accessibility on Libreoffice menus

Test Case:

Reproducible 95% of the time here
 * Open libreofice writer
 * Open orca
 * Open file->new submenu

Regression potential:

Close to none, it's just checking for some pointers to be non null before using them

[Albert Astals Cid (aacid)]

Adding unity, since what i get to crash is unity-panel-service that belongs to the unit project

[Omer Akram (om26er)]

Thank you for taking the time to report this bug and helping to make Ubuntu better. Please answer these questions:

* Is this reproducible?
* If so, what specific steps should we take to recreate this bug?

This will help us to find and resolve the problem.

[Albert Astals Cid (aacid)]

Reproducible 95% of the time here
 * Open libreofice writer
 * Open orca
 * Open file->new submenu
 * Crash

[Albert Astals Cid (aacid)]

Seems the crash is at least caused by a gtk bug in assuming a widget will always have a window https://bugzilla.gnome.org/show_bug.cgi?id=686152

Not sure if there may be some other bug lying around

[Albert Astals Cid (aacid)]

As said, gtk bug, patch reported at https://bugzilla.gnome.org/show_bug.cgi?id=686152

[Albert Astals Cid (aacid)]

Fixed upstream gtk in http://git.gnome.org/browse/gtk+/commit/?id=bec6b260b4139d955367fa4a869c7a2cd69bf6e5

[Albert Astals Cid (aacid)]

Subscribed ubuntu-sponsors as seb128 suggested

Here SRU information:
 * Impact: Fixes crash on using accessibility on Libreoffice menus
 * Test Case: Please see comment #3
 * Regression potential: Close to none, it's just checking for some pointers to be non null before using them
 * Path: Please see comment #6

[Björn Michaelsen (bjoern-michaelsen)]

Related too bug 1071725, likely the same root cause.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gtk+3.0 - 3.6.0-0ubuntu4

---------------
gtk+3.0 (3.6.0-0ubuntu4) raring; urgency=low

  * debian/patches/git_robust_a11y_unrealized.patch: "Be robust against
    unrealized windows in GtkWindowAccessible" (lp: #1064992)

gtk+3.0 (3.6.0-0ubuntu3.1) quantal-proposed; urgency=low

  * Cherry-pick some upstream patches from 3.6.1 (LP: #1068585)
    + appchooserwidget: check for g_app_info_should_show(). This ensures
      NoDisplay=true or NotShowIn/OnlyShowIn values in the desktop file are
      respected.
    + Make process_all_updates draw synchronously to improve rendering
      performance.
 -- Sebastien Bacher <email address hidden> Fri, 09 Nov 2012 17:47:37 +0100

[Brian Murray (brian-murray)]

The upload in the quantal -proposed queue that fixes this also has an undocumented change in it:

diff -Nru gtk+3.0-3.6.0/debian/changelog gtk+3.0-3.6.0/debian/changelog
--- gtk+3.0-3.6.0/debian/changelog 2012-10-19 11:35:41.000000000 +0000
+++ gtk+3.0-3.6.0/debian/changelog 2012-11-09 16:57:51.000000000 +0000
@@ -1,3 +1,10 @@
+gtk+3.0 (3.6.0-0ubuntu3.2) quantal-proposed; urgency=low
+
+ * debian/patches/git_robust_a11y_unrealized.patch: "Be robust against
+ unrealized windows in GtkWindowAccessible" (lp: #1064992)
+
+ -- Sebastien Bacher <email address hidden> Fri, 09 Nov 2012 17:47:37 +0100
+
 gtk+3.0 (3.6.0-0ubuntu3.1) quantal-proposed; urgency=low

   * Cherry-pick some upstream patches from 3.6.1 (LP: #1068585)
...
diff -Nru gtk+3.0-3.6.0/debian/patches/series gtk+3.0-3.6.0/debian/patches/series
--- gtk+3.0-3.6.0/debian/patches/series 2012-10-19 11:35:41.000000000 +0000
+++ gtk+3.0-3.6.0/debian/patches/series 2012-11-09 16:57:51.000000000 +0000
@@ -3,7 +3,6 @@
 018_gdkenumtypes.c_location.patch
 022_disable-viqr-im-for-vi-locale.patch
 044_tracker_fts.patch
-061_multiarch_module_fallback.patch
 043_ubuntu_menu_proxy.patch
 062_ubuntu-set-grab-add.patch
 071_fix-installation-of-HTML-images.patch
@@ -18,3 +17,4 @@
 git_iconview_render_item_select.patch
 git_appchooser_check_should_show.patch
 git_process_all_updates_synchronous.patch
+git_robust_a11y_unrealized.patch

Why was 061_multiarch_module_fallback.patch dropped? Should that be noted in the changelog?

[Sebastien Bacher (seb128)]

Thanks Brian for catching that, it was an error, I've rejected the upload and did a new one

[Brian Murray (brian-murray)]

Hello Antonio, or anyone else affected,

Accepted gtk+3.0 into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/gtk+3.0/3.6.0-0ubuntu3.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Antonio Fernández (antonio-fernandez-vega)]

@Brian

It looks that the patch fix the issue in my case. Nice work!

[Chris Halse Rogers (raof)]

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gtk+3.0 - 3.6.0-0ubuntu3.2

---------------
gtk+3.0 (3.6.0-0ubuntu3.2) quantal-proposed; urgency=low

  * debian/patches/git_robust_a11y_unrealized.patch: "Be robust against
    unrealized windows in GtkWindowAccessible" (lp: #1064992)
 -- Sebastien Bacher <email address hidden> Fri, 09 Nov 2012 17:47:37 +0100