Editing file after changing tab in filebrowser crashes the block editor

[Melissa Draper]

If you add a block of type gallery or file, then switch the tabs to Group files or Site files then back to My files, the block editing popup will disappear when you click the edit button for a file in the list.

Firefox 14.0.1

[Melissa Draper (melissa)]

Throws the following error messages:

[WAR] 33 (artefact/file/form/elements/filebrowser.php:316) Undefined offset: 0
Call stack (most recent first):

    log_message("Undefined offset: 0", 8, true, true, "/var/www/maharadev/code/htdocs/artefact/file/form/...", 316) at /var/www/maharadev/code/htdocs/lib/errors.php:446
    error(8, "Undefined offset: 0", "/var/www/maharadev/code/htdocs/artefact/file/form/...", 316, array(size 9)) at /var/www/maharadev/code/htdocs/artefact/file/form/elements/filebrowser.php:316
    pieform_element_filebrowser_configure_tabs(array(size 2), "instconf_folder") at /var/www/maharadev/code/htdocs/artefact/file/form/elements/filebrowser.php:1238
    pieform_element_filebrowser_changeowner(object(Pieform), array(size 14)) at /var/www/maharadev/code/htdocs/artefact/file/form/elements/filebrowser.php:689
    pieform_element_filebrowser_doupdate(object(Pieform), array(size 14)) at /var/www/maharadev/code/htdocs/artefact/file/form/elements/filebrowser.php:362
    pieform_element_filebrowser_get_value(object(Pieform), array(size 14)) at /var/www/maharadev/code/htdocs/lib/pieforms/pieform.php:802
    Pieform->get_value(array(size 14)) at /var/www/maharadev/code/htdocs/lib/pieforms/pieform.php:1253
    Pieform->get_submitted_values() at /var/www/maharadev/code/htdocs/lib/pieforms/pieform.php:490
    Pieform->__construct(array(size 15)) at /var/www/maharadev/code/htdocs/blocktype/lib.php:872
    BlockInstance->build_configure_form() at /var/www/maharadev/code/htdocs/view/blocks.php:87

[WAR] 33 (artefact/file/form/elements/filebrowser.php:316) Trying to get property of non-object
Call stack (most recent first):

    log_message("Trying to get property of non-object", 8, true, true, "/var/www/maharadev/code/htdocs/artefact/file/form/...", 316) at /var/www/maharadev/code/htdocs/lib/errors.php:446
    error(8, "Trying to get property of non-object", "/var/www/maharadev/code/htdocs/artefact/file/form/...", 316, array(size 9)) at /var/www/maharadev/code/htdocs/artefact/file/form/elements/filebrowser.php:316
    pieform_element_filebrowser_configure_tabs(array(size 2), "instconf_folder") at /var/www/maharadev/code/htdocs/artefact/file/form/elements/filebrowser.php:1238
    pieform_element_filebrowser_changeowner(object(Pieform), array(size 14)) at /var/www/maharadev/code/htdocs/artefact/file/form/elements/filebrowser.php:689
    pieform_element_filebrowser_doupdate(object(Pieform), array(size 14)) at /var/www/maharadev/code/htdocs/artefact/file/form/elements/filebrowser.php:362
    pieform_element_filebrowser_get_value(object(Pieform), array(size 14)) at /var/www/maharadev/code/htdocs/lib/pieforms/pieform.php:802
    Pieform->get_value(array(size 14)) at /var/www/maharadev/code/htdocs/lib/pieforms/pieform.php:1253
    Pieform->get_submitted_values() at /var/www/maharadev/code/htdocs/lib/pieforms/pieform.php:490
    Pieform->__construct(array(size 15)) at /var/www/maharadev/code/htdocs/blocktype/lib.php:872
    BlockInstance->build_configure_form() at /var/www/maharadev/code/htdocs/view/blocks.php:87

[Melissa Draper (melissa)]

This is a regression from 1.5

[Son Nguyen (ngson2000)]

https://reviews.mahara.org/#/c/1744/

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1744
Committed: http://gitorious.org/mahara/mahara/commit/6661096557f82400b34a6876fc0e51e79dccf11c
Submitter: Melissa Draper (<email address hidden>)
Branch: master

commit 6661096557f82400b34a6876fc0e51e79dccf11c
Author: Son Nguyen <email address hidden>
Date: Wed Oct 3 19:08:57 2012 +1300

    Update the 'editmeta' value when change owner (bug #1060495)

    When switch from 'Group files' to 'My files' in file browser, fix the
    'editmeta' config value.

    Change-Id: Ib559e26231f29b24fd18c9e5a40531bc20c59ee4
    Signed-off-by: Son Nguyen <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1748
Committed: http://gitorious.org/mahara/mahara/commit/e160895759d943fd0c69b64435edd113decda6d2
Submitter: Melissa Draper (<email address hidden>)
Branch: 1.6_STABLE

commit e160895759d943fd0c69b64435edd113decda6d2
Author: Son Nguyen <email address hidden>
Date: Wed Oct 3 19:08:57 2012 +1300

    Update the 'editmeta' value when change owner (bug #1060495)

    When switch from 'Group files' to 'My files' in file browser, fix the
    'editmeta' config value.

    Change-Id: Ib559e26231f29b24fd18c9e5a40531bc20c59ee4
    Signed-off-by: Son Nguyen <email address hidden>

[Hugh Davenport (hugh-davenport)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iJwEAQECAAYFAlCbHO8ACgkQuMoJ2LQ3zxH8TAP/YN4BiCJZsn5a899/0UzV31Qg
lM8LXAwZWa6zFv6t0BQUHCqe6eFK9wPp51qgCWWXjUZ3vvvVcsyeWp6626aBFKSU
pCQXI9E7huPw802nJQ9WcZXRBUmgw87ww72Tx4mybnu7SPSrkZgXdnPGSMwDs89N
oWvTpl7Xuac48e6p0lU=
=ouU+
-----END PGP SIGNATURE-----