Login screen doesn't show reason for being logged out

Bug #1060426 reported by Gabriel Hurley
26
This bug affects 5 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Gabriel Hurley

Bug Description

If you are logged out (due to being unauthorized, or your session expiring) you are redirected to the login screen with no explanation. Ideally there would be a message indicating why you were logged out.

Changed in horizon:
assignee: Nebula (nebula) → nobody
Changed in horizon:
assignee: nobody → Lin Hua Cheng (lin-hua-cheng)
Changed in horizon:
assignee: Lin Hua Cheng (lin-hua-cheng) → nobody
Changed in horizon:
milestone: grizzly-1 → grizzly-2
Changed in horizon:
milestone: grizzly-2 → grizzly-3
Changed in horizon:
milestone: grizzly-3 → none
Changed in horizon:
milestone: none → grizzly-rc1
importance: Medium → High
assignee: nobody → Gabriel Hurley (gabriel-hurley)
Revision history for this message
Lin Hua Cheng (lin-hua-cheng) wrote :

There are two login pages in horizon, one through splash.html and the other through login.html.

Splash.html does not import any of the javascript library. I think what used to happened is the user is redirected to splash.html instead of login.html.

The fix made by Kieran Spear in https://review.openstack.org/#/c/16287/ ensures that the user is redirected to login.html. And the message is now displaying correctly.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24604

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/24604
Committed: http://github.com/openstack/horizon/commit/e1d12a4e49ab720f69b8a82a573faf68d1d8761f
Submitter: Jenkins
Branch: master

commit e1d12a4e49ab720f69b8a82a573faf68d1d8761f
Author: Gabriel Hurley <email address hidden>
Date: Sun Mar 17 12:14:29 2013 -0700

    Improve UX around "unauthorized" API exceptions.

    Instead of blindly logging out the user when any API returns
    a 401 or 403 response (which in most cases is due to a service
    being down or misconfigured) we catch the error and inform the
    user that they are not authorized for that data.

    This is separate from being unauthorized for a dashboard or
    panel in Horizon, since those are within our control and involve
    security concerns around exposing admin functionalities to end
    users. Those checks function as they have previously.

    Fixes bug 1060426.

    Change-Id: Ied800f10926ac5fb3b9ac1c1c26bbb4fa94a2557

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.