removing image in block before adding new one causes upload failure

[Melissa Draper]

Version: master
Browser: Firefox 14.0.1
OS: Ubuntu

To reproduce:
* Add gallery block to page
* Choose the individual images radio
* Upload an image or select an image from the list shown
* Change your mind and remove the image
* Upload another image -- the uploading hangs and the image is called "undefined".

This is a regression. It worked fine on 1.5_STABLE.

[Melissa Draper (melissa)]

Does not happen on chrome.

Possibly to do with the fix for bug #1030665

[Son Nguyen (ngson2000)]

https://reviews.mahara.org/#/c/1742/

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1797
Committed: http://gitorious.org/mahara/mahara/commit/8255481d4cf40bf74df8519fc96372593ffe0a49
Submitter: Hugh Davenport (<email address hidden>)
Branch: 1.6_STABLE

commit 8255481d4cf40bf74df8519fc96372593ffe0a49
Author: Son Nguyen <email address hidden>
Date: Wed Oct 3 17:45:07 2012 +1300

    Replace the call removeElement() in filebrowser.js (bug #1057846)

    This call causes the callback() not to call after upload.

    1. When click 'Remove', keep the file in the selected list, only hide
    it, remove the hidden input element
    2. When click 'Select' or Upload a new file, add new row or update the
    selected list.
    3. When update file title and description, update the list
    4. When change 'Image selection', recalculate the width of the
    configuration box
    5. After update file title and description and upload a file,
    recalculate the width of the configuration box

    Change-Id: I57b97c13086df3b5c828c9b731ebae9a00cd2d69
    Signed-off-by: Son Nguyen <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1742
Committed: http://gitorious.org/mahara/mahara/commit/a9bd7f9be8ed20a696bf8b7352c7078f98cde826
Submitter: Melissa Draper (<email address hidden>)
Branch: master

commit a9bd7f9be8ed20a696bf8b7352c7078f98cde826
Author: Son Nguyen <email address hidden>
Date: Wed Oct 3 17:45:07 2012 +1300

    Replace the call removeElement() in filebrowser.js (bug #1057846)

    This call causes the callback() not to call after upload.

    1. When click 'Remove', keep the file in the selected list, only hide
    it, remove the hidden input element
    2. When click 'Select' or Upload a new file, add new row or update the
    selected list.
    3. When update file title and description, update the list
    4. When change 'Image selection', recalculate the width of the
    configuration box
    5. After update file title and description and upload a file,
    recalculate the width of the configuration box

    Change-Id: I57b97c13086df3b5c828c9b731ebae9a00cd2d69
    Signed-off-by: Son Nguyen <email address hidden>

[Hugh Davenport (hugh-davenport)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iJwEAQECAAYFAlCbHO8ACgkQuMoJ2LQ3zxH8TAP/YN4BiCJZsn5a899/0UzV31Qg
lM8LXAwZWa6zFv6t0BQUHCqe6eFK9wPp51qgCWWXjUZ3vvvVcsyeWp6626aBFKSU
pCQXI9E7huPw802nJQ9WcZXRBUmgw87ww72Tx4mybnu7SPSrkZgXdnPGSMwDs89N
oWvTpl7Xuac48e6p0lU=
=ouU+
-----END PGP SIGNATURE-----