Binaries only use default topics

Bug #1057831 reported by Michael H Wilson
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Michael H Wilson

Bug Description

Found the bug in Essex 2012.2, but it appears to also be affecting folsom release candidates and the current head.

When you specify topics for different nova components their binaries don't start them up with that topic. This seems inconsistent with the rest of the messaging API which always refers to FLAGS.binary_topic. I had to fix this by patching all the nova binaries and by patching nova.service.Service.create.

I did not patch nova-all, I'm not sure if people still use this, I don't.

Changed in nova:
assignee: nobody → Michael H Wilson (geekinutah)
Revision history for this message
Michael H Wilson (geekinutah) wrote :

Updated the patch to include breakage in nova/db/sqlalchemy/api.py.

Revision history for this message
Michael H Wilson (geekinutah) wrote :

This affects stuff all over the codebase, I should have a few more patches in on Monday. Stay tuned till then.

Tom Fifield (fifieldt)
Changed in nova:
status: New → Confirmed
Revision history for this message
Michael H Wilson (geekinutah) wrote :

-Added another fix for nova/db/sqlalchemy/api.py.
-Fix for scheduler binary was broken before, better now.

Revision history for this message
Michael H Wilson (geekinutah) wrote :

I think this is everything. This latest patch is against master.

Revision history for this message
Michael H Wilson (geekinutah) wrote :

That last patch had a bug for consoleauth, fixed that. Here's the new one.

Revision history for this message
Michael H Wilson (geekinutah) wrote :

Found some more damage, here it is:

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/14498

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/14504

Revision history for this message
Michael H Wilson (geekinutah) wrote :

Here's the latest patch against stable/folsom.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/14504
Committed: http://github.com/openstack/nova/commit/0bf28bec6097d128aa439b288b249fafcac7dbc0
Submitter: Jenkins
Branch: master

commit 0bf28bec6097d128aa439b288b249fafcac7dbc0
Author: Michael H Wilson <email address hidden>
Date: Tue Oct 16 15:47:52 2012 -0600

    Fix hardcoded topic strings with constants.

    Replace hardcoded topic strings like 'volume' or 'compute'
    with config constants like FLAGS.volume_topic, etc. See
    bug #1057831 and bug #1061628.

    Change-Id: I817ecc3cbe3245b51a0c047be58d17edfec8a838

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.