Searches fail across changes in case
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unity-lens-applications |
Fix Released
|
High
|
Michal Hruby | ||
5.0 |
Fix Released
|
High
|
Michal Hruby | ||
unity-lens-applications (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Precise |
Fix Released
|
Undecided
|
Timo Jyrinki |
Bug Description
[IMPACT]
* Currently application lens tokenizes applications names on change in the case. This means an application named "AisleRiot" can be found by searching "aisle" or "riot" (or any of its prefixes), but not the full name "aisleriot". This may cause the users to not find an application.
* Fix for this is already present in Quantal, and since searching for applications is one of primary uses of dash, it should be backported to Precise.
* Despite what the original description says, full substring matching is not desired (ie "leriot" should NOT find "AisleRiot".
[TESTCASE]
* Before the fix - observe that searching for "aisle" finds "AisleRiot Solitaire" (it is installed by default), but searching for "aisleri" doesn't match any applications.
* With fix - seaching for "aisleri" correctly finds AisleRiot.
* Note that this may seemed to work properly in P for some CamelCase applications (like LibreOffice, but that's because "office" is present in the binary name)
[Regression Potential]
Possible regressions:
* Searching for the individual tokens no longer works.
=======
Original description:
Application Lens searches seem to be based on tokens of entire words, not substrings. They are delimited by whitespace or changes in capitalisation. If you attempt to search across changes in case, or in the middle of a word, the search fails.
For example, I have Handbrake installed (http://
1. hand
2. brake
The following Lens searches DO NOT find Handbrake:
1. Handbrake
2. HandBrake
3. Handb
4. and
5. rake
I would expect any of these searches to produce it. Even disregarding the substring matches in cases 4 and 5, cases 1-3 should work.
Related branches
- Paweł Stołowski (community): Approve
-
Diff: 73 lines (+33/-9)3 files modifiedconfigure.ac (+1/-1)
src/utils.vala (+6/-1)
tests/manual/apps-lens-tests.txt (+26/-7)
- Paweł Stołowski (community): Approve
-
Diff: 60 lines (+32/-8)2 files modifiedsrc/utils.vala (+6/-1)
tests/manual/apps-lens-tests.txt (+26/-7)
Changed in unity-lens-applications: | |
status: | New → Confirmed |
Changed in unity-lens-applications (Ubuntu): | |
status: | New → Confirmed |
Changed in unity-lens-applications: | |
importance: | Undecided → High |
status: | Confirmed → Triaged |
milestone: | none → 6.8.0 |
Changed in unity-lens-applications: | |
status: | Triaged → Fix Committed |
Changed in unity-lens-applications: | |
assignee: | nobody → Michal Hruby (mhr3) |
description: | updated |
summary: |
- Searches fail across changes in case or in middle of word + Searches fail across changes in case |
Changed in unity-lens-applications: | |
status: | Fix Committed → Fix Released |
Changed in unity-lens-applications (Ubuntu Precise): | |
status: | New → In Progress |
assignee: | nobody → Timo Jyrinki (timo-jyrinki) |
Note that substrings matching the begin of a word do work. Examples:
3. han
4. brak