A blank ts_control file leads to a schema validation error
Bug #1055802 reported by
Joe Talbott
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
UTAH |
Fix Released
|
Low
|
Javier Collado |
Bug Description
Since none of the metadata in the ts_control file is mandatory a blank ts_control file should be accepted.
The error I receive is:
'testit' test suite control file invalid: 'testit/ts_control'
Detailed information: None is not of type 'object'
The expected behavior is that the file should be accepted by the schema validation code.
Related branches
lp:~javier.collado/utah/bug1055802
- Joe Talbott (community): Approve
-
Diff: 89 lines (+24/-4)4 files modifiedutah/client/common.py (+6/-1)
utah/client/exceptions.py (+8/-1)
utah/client/runner.py (+5/-1)
utah/client/testsuite.py (+5/-1)
Changed in utah: | |
status: | New → Triaged |
importance: | Undecided → Low |
assignee: | nobody → Javier Collado (javier.collado) |
status: | Triaged → In Progress |
Changed in utah: | |
status: | In Progress → Fix Committed |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
@Joe
I think that the problem here is that the schema validation expects a dictionary object and instead of None. Hence, the minimum file must contain '{}'.
If you want to support empty files, then the schema should be updated or we can provide a default value is the file is empty. I think I'd be in favor of the latter, since I think it's better to keep the schema as simple as possible for this.
Aside from empty files, would you like to support not having any file at all as well?