SolarisISCSIDriver does not work

[Yosef Berman]

When the create_volume method is called in the SolarisISCSIDriver class, the _execute method from the utils module is called. It should be running the _execute command in the SolarisISCSIDriver.

[John Griffith (john-griffith)]

Please verify that you have the FLAGS.san_is_local flag set appropriately.

If True it is in fact supposed to use utils._execute, otherwise it uses ssh.

[Yosef Berman (yosef-4)]

I set san_is_local to false in /etc/cinder/cinder.conf and it still used utils._execute. I believe the code in the VolumeDriver's init method is called, which overwrites the _execute method in the SolarisISCSIDriver.

[John Griffith (john-griffith)]

Ahh.... Yup, need to replace the calls to self._execute() with super(SolarisISCSIDriver, self)._execute()

My question is "how long has this been broken", seems it's been there *forever*?

[Yosef Berman (yosef-4)]

Perhaps we can create an __init__ method in SolarisISCSIDriver which passes up the execute key word argument set to the correct _execute? That way when it hits the base classes __init__, the correct _execute will be passes into set_execute.

[John Griffith (john-griffith)]

Yes, using super().__init__ works as well. Or just factor out the use of Super altogether :)

Regardless, if there's an install base we could target for RC2 and try to get it fixed. I'm assuming you have hardware to test against?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/13391

[Thierry Carrez (ttx)]

If it's in cinder rc2, needs to be in nova rc2... (or remove the targeting for both)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/13420

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/13391
Committed: http://github.com/openstack/cinder/commit/3b8a6303e6c04f0c7b45043c2fcd53948910d37e
Submitter: Jenkins
Branch: master

commit 3b8a6303e6c04f0c7b45043c2fcd53948910d37e
Author: Yosef Berman <email address hidden>
Date: Thu Sep 20 10:34:24 2012 -0700

    Fixes to the SolarisISCSI Driver

    Even when the san_is_local config option was set to false, the
    SolarisISCSIDriver's _execute method was accidentally set to
    util.execute by the VolumeDriver's __init__ method.

    Fix bug 1053041

    Change-Id: Ie3299f5065e2b084644ec2956f0c6ebae4264a49

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/13429

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/13429
Committed: http://github.com/openstack/cinder/commit/b33bf44eca13520587c94f00798988cee49475c9
Submitter: Jenkins
Branch: milestone-proposed

commit b33bf44eca13520587c94f00798988cee49475c9
Author: Yosef Berman <email address hidden>
Date: Thu Sep 20 10:34:24 2012 -0700

    Fixes to the SolarisISCSI Driver

    Even when the san_is_local config option was set to false, the
    SolarisISCSIDriver's _execute method was accidentally set to
    util.execute by the VolumeDriver's __init__ method.

    Fix bug 1053041

    Change-Id: Ie3299f5065e2b084644ec2956f0c6ebae4264a49
    (cherry picked from commit 3b8a6303e6c04f0c7b45043c2fcd53948910d37e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/13420
Committed: http://github.com/openstack/nova/commit/c27312c2efb31b9ec88f5635029f9d2dc8667b50
Submitter: Jenkins
Branch: master

commit c27312c2efb31b9ec88f5635029f9d2dc8667b50
Author: Yosef Berman <email address hidden>
Date: Thu Sep 20 15:09:17 2012 -0700

    Fixes to the SolarisISCSI Driver

    Even when the san_is_local config option was set to false, the
    SolarisISCSIDriver's _execute method was accidentally set to
    util.execute by the VolumeDriver's __init__ method.

    Fix bug 1053041

    Change-Id: Ifd8436874759d75633da3dbbfa01bd99f979ddea

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/13476

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/13476
Committed: http://github.com/openstack/nova/commit/b51facbdb2e17e2136c5d29ae923e59df83a6c98
Submitter: Jenkins
Branch: milestone-proposed

commit b51facbdb2e17e2136c5d29ae923e59df83a6c98
Author: Yosef Berman <email address hidden>
Date: Thu Sep 20 15:09:17 2012 -0700

    Fixes to the SolarisISCSI Driver

    Even when the san_is_local config option was set to false, the
    SolarisISCSIDriver's _execute method was accidentally set to
    util.execute by the VolumeDriver's __init__ method.

    Fix bug 1053041

    Change-Id: Ifd8436874759d75633da3dbbfa01bd99f979ddea