Incorrect cast from int to pointer
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Nux | Status tracked in 4.0 | |||||
3.0 |
Won't Fix
|
Medium
|
Jay Taoko | |||
4.0 |
Fix Released
|
Medium
|
Jay Taoko | |||
nux (Ubuntu) |
Fix Released
|
Medium
|
Jay Taoko |
Bug Description
./GpuDeviceVert
er>, nux::ObjectPtr<
./GpuDeviceVert
The code is:
CHECKGL(
GL_FALSE,
vtxelement.Offset is of type int, so the compiler rightfully complains about a cast from a 4-byte int to an 8-byte void*.
It looks like something is missing here, such as a stream pointer to which the offset should be added, but it's not clear to me what the correct fix is. But, as it stands, it's certainly incorrect.
Related branches
- Nicolas d'Offay (community): Approve
- Eleni Maria Stea (community): Approve
- Michi Henning (community): Approve
-
Diff: 1259 lines (+267/-229)18 files modifiedNux/Theme.cpp (+20/-17)
NuxCore/FileIO.cpp (+9/-9)
NuxCore/FileIO.h (+3/-3)
NuxGraphics/FontRenderer.cpp (+2/-2)
NuxGraphics/GLError.cpp (+2/-0)
NuxGraphics/GLRenderStates.cpp (+2/-2)
NuxGraphics/GLRenderStates.h (+9/-9)
NuxGraphics/GLShaderParameter.h (+2/-2)
NuxGraphics/GpuDevice.cpp (+114/-75)
NuxGraphics/GpuDevice.h (+22/-32)
NuxGraphics/GpuDeviceVertex.cpp (+1/-1)
NuxGraphics/GraphicsEngine.cpp (+1/-1)
NuxGraphics/GraphicsEngine.h (+3/-3)
NuxGraphics/IOpenGLAsmShader.cpp (+9/-9)
NuxGraphics/IOpenGLAsmShader.h (+2/-2)
NuxGraphics/IOpenGLCgShader.h (+6/-6)
NuxGraphics/IOpenGLGLSLShader.cpp (+51/-47)
NuxGraphics/IOpenGLGLSLShader.h (+9/-9)
Changed in nux: | |
milestone: | none → 3.4 |
Changed in nux (Ubuntu): | |
status: | New → Fix Released |
assignee: | nobody → Jay Taoko (jaytaoko) |
importance: | Undecided → Medium |
Fixed on trunk by revisiont 676.