ovs plugin failed to remove old physical network vlan id allocaton entryies during sync

Bug #1052289 reported by yong sheng gong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Robert Kukura

Bug Description

When quantum server starts, the ovs plugin will try to syn the vlan id allocation entries. It can only remove unused id allocation entries, but fail to remove unused physical network.
reproducing steps:
1. network_vlan_ranges = physnet1:1000:1999,physnet2:2000:2999
bridge_mappings = physnet1:br-eth1,physnet2:br-eth2

start the quantum-server and stop
2.network_vlan_ranges = physnet1:1000:1999
bridge_mappings = physnet1:br-eth1

start the quantum-server and stop

the physnet2's vlan id allocation entries are still existing.

expected:
the whole physnet2 should be deleted from vlan allocaton tables.

Changed in quantum:
importance: Undecided → Medium
Robert Kukura (rkukura)
Changed in quantum:
assignee: nobody → Robert Kukura (rkukura)
Robert Kukura (rkukura)
tags: added: folsom-rc-potential
Revision history for this message
Robert Kukura (rkukura) wrote :

Confirmed this issue exists in both the openvswitch and linuxbridge plugins.

Changed in quantum:
status: New → In Progress
milestone: none → folsom-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/13407

Thierry Carrez (ttx)
tags: removed: folsom-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/13407
Committed: http://github.com/openstack/quantum/commit/6bae24df4e6d5a339dc4259b8c996bf452d7be28
Submitter: Jenkins
Branch: master

commit 6bae24df4e6d5a339dc4259b8c996bf452d7be28
Author: Bob Kukura <email address hidden>
Date: Thu Sep 20 16:03:14 2012 -0400

    Fix OVS and LB plugins' VLAN allocation table synchronization

    In both the openvswitch and linuxbridge plugins, if previous entries
    for a physical network have been completely removed from the
    network_vlan_ranges configuration variable, allocation table records
    for unallocated VLANs on that physical network are now removed from
    the DB at startup. The test_ovs_db and test_lb_db unit tests have also
    been extended to cover this case. Fixes bug 1052289.

    Test assertions that were added to the test_ovs_db unit test in
    https://review.openstack.org/#/c/11388 have been added to the
    test_lb_db unit test. Fixes bug 1045596.

    Change-Id: I04e924603eaf0df717414c2aaa83fd203b791308

Changed in quantum:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/13470

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (milestone-proposed)

Reviewed: https://review.openstack.org/13470
Committed: http://github.com/openstack/quantum/commit/a2fb340097fab44e6b8915102577b769fb5ffac2
Submitter: Jenkins
Branch: milestone-proposed

commit a2fb340097fab44e6b8915102577b769fb5ffac2
Author: Bob Kukura <email address hidden>
Date: Thu Sep 20 16:03:14 2012 -0400

    Fix OVS and LB plugins' VLAN allocation table synchronization

    In both the openvswitch and linuxbridge plugins, if previous entries
    for a physical network have been completely removed from the
    network_vlan_ranges configuration variable, allocation table records
    for unallocated VLANs on that physical network are now removed from
    the DB at startup. The test_ovs_db and test_lb_db unit tests have also
    been extended to cover this case. Fixes bug 1052289.

    Test assertions that were added to the test_ovs_db unit test in
    https://review.openstack.org/#/c/11388 have been added to the
    test_lb_db unit test. Fixes bug 1045596.

    Change-Id: I04e924603eaf0df717414c2aaa83fd203b791308

Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-rc2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.