Some server attributes are not de-serialized from XML during create

[Dan Smith]

The following are server attributes which are not de-serialized in servers.CommonDeserializer._extract_server() but later used in servers.Controller.create():

 - block_device_mapping
 - availability_zone
 - return_reservation_id
 - min_count
 - max_count
 - scheduler_hints

This means that servers cannot be created via an XML representation if using those attributes.

[Matthew Treinish (treinish)]

See bug 150797 for user_data failure: https://bugs.launchpad.net/nova/+bug/1050797

[Matthew Treinish (treinish)]

That should be bug 1050797, I missed a '0' above

[Mark McLoughlin (markmc)]

This bug originally was about rebuild action de-serialization:

  Server Rebuild:

  The following attributes aren't honored when calling server rebuild via XML:
   - adminPass
   - accessIPv4
   - accessIPv6

  This was uncovered during api_sample test development for server actions:

  https://review.openstack.org/#/c/13035/

But this issue was fixed by https://review.openstack.org/13033

I'm not really sure why we re-purposed this bug for another issue, but ...

[Mark McLoughlin (markmc)]

Also removed the reference to the user_data issue from the description since that is handled by bug 1050797

[Mark McLoughlin (markmc)]

https://review.openstack.org/12940 fixes the scheduler_hints piece

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/12940
Committed: http://github.com/openstack/nova/commit/81e76480af6ad17943cd2385a045d24217b07a7b
Submitter: Jenkins
Branch: master

commit 81e76480af6ad17943cd2385a045d24217b07a7b
Author: Mauro S. M. Rodrigues <email address hidden>
Date: Thu Sep 13 01:59:43 2012 -0400

    Include Schedule Hints deserialization to XML API

    So far the xml format to schedule hints were not defined.
    Once defined (in ML), this patch add support to its deserialization.

    This patch also includes a xml deserialization method to get the Elements
    between the childs of a node.

    Partially fixes bug 1050997

    Change-Id: I2a34dbbd6200755818d7eaa7330a96d61a043614

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/13221

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/13222

[Vish Ishaya (vishvananda)]

patches in queue for everything but block_device_mapping. Probably going to push block_device_mapping out of folsom and list it as a known issue.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/13221
Committed: http://github.com/openstack/nova/commit/71c9677d803a722f5c9eb5b2d0719f1e713d1b7b
Submitter: Jenkins
Branch: master

commit 71c9677d803a722f5c9eb5b2d0719f1e713d1b7b
Author: Vishvananda Ishaya <email address hidden>
Date: Tue Sep 18 11:56:54 2012 -0700

    Add deserialization for multiple create and az

    We were not deserializing xml values causing the multiple create
    extension and the availability zone extension to fail with xml.

    This adds deserialization for these attributes and adds tests

    Part of bug 1050997

    Change-Id: Ic40ce58b0854717dd99dba8ed39c861e31e6bba4

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/13222
Committed: http://github.com/openstack/nova/commit/8d43c3fba1a5e07703cae6f7b631d0787c4f41bb
Submitter: Jenkins
Branch: master

commit 8d43c3fba1a5e07703cae6f7b631d0787c4f41bb
Author: Vishvananda Ishaya <email address hidden>
Date: Tue Sep 18 12:02:50 2012 -0700

    Makes scheduler hints and disk config xml correct

    The scheduler hints and disk config extensions were not using
    proper prefixes when deserializing xml. This patch modifes
    them to deserialize properly. It leaves the old deserialization
    in place as well so anyone using the broken implementation
    will continue to work.

    It also updates the api samples to use the new format. Note that
    the proper fix required changing the alias for the scheduler hints
    extension, since the alias is used for xml, so the samples had
    to be moved.

    Finally it fixes an issue with deserialization, allowing it to
    support multiple hints with the same name.

    Part of bug 1050997

    Change-Id: I9969582d65d44de25388f07b6d2013fb7d093fb2