don't add commas when adding tags through modify_tags dialog

[Nimit Shah]

Current implementation of GTG, adds commas after tags when added by modify tags dialog box but these commas are not removed when tags are removed (even if we use !tag_name in modify_tag dialog).
 Instead of modifying the delete tag function to check for trailing comma it is better that we stop adding commas after tags. The reason being, it is not necessary that the comma is added by modify_tag dialog box only.

[Izidor Matušov (izidor)]

I think this is much more deeper issue. Sometimes when you have tags on the second line of a task without commas, adding a new tag moves them to about 4th line and create a new 2nd line. (Or when you don't have the last comma?) Something like:

<code>
Title
@new_tag

@old_a @old_b

Description
</code>

This should be part of editor rework. Nimit, don't you as a frequent contributor start working on this? Analyze how the "2nd line" currently works, design how it should work and then implement it when we merge Steve's GSoC code. It could be a nice little big project for you (and could be more challenging as well).

At the end of day, I don't think this is love bug and it need deeper investigation to solve it in general way.

[Nimit Shah (nimit-svnit)]

Thank you izidor to point that out!
  I'll work on that.

On 9/14/12, Izidor Matušov <email address hidden> wrote:
> I think this is much more deeper issue. Sometimes when you have tags on
> the second line of a task without commas, adding a new tag moves them
> to about 4th line and create a new 2nd line. (Or when you don't have the
> last comma?) Something like:
>
> <code>
> Title
> @new_tag
>
> @old_a @old_b
>
> Description
> </code>
>
> This should be part of editor rework. Nimit, don't you as a frequent
> contributor start working on this? Analyze how the "2nd line" currently
> works, design how it should work and then implement it when we merge
> Steve's GSoC code. It could be a nice little big project for you (and
> could be more challenging as well).
>
> At the end of day, I don't think this is love bug and it need deeper
> investigation to solve it in general way.
>
> ** Tags removed: love modifytags
> ** Tags added: editor
>
> ** Changed in: gtg
> Status: New => Incomplete
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1050782
>
> Title:
> don't add commas when adding tags through modify_tags dialog
>
> Status in Getting Things GNOME!:
> Incomplete
>
> Bug description:
> Current implementation of GTG, adds commas after tags when added by modify
> tags dialog box but these commas are not removed when tags are removed (even
> if we use !tag_name in modify_tag dialog).
> Instead of modifying the delete tag function to check for trailing comma
> it is better that we stop adding commas after tags. The reason being, it is
> not necessary that the comma is added by modify_tag dialog box only.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/gtg/+bug/1050782/+subscriptions
>

--
Nimit Shah,
B Tech 4th year,
Computer Engineering Department,
SVNIT Surat
www.dude-says.blogspot.com

[Nimit Shah (nimit-svnit)]

Okay so this is what happens:
->The task body is completely empty
    New tag is added with no commas or new lines following it

-> The task body contains only tag(s)
    New tag is added followed by a comma, at the start of the first line

-> The first and second line of body have tag(s)
    New tag is added followed by comma, at the start of the first line

->The first line has a tag but the next line does not
    New tag is added in the first line followed by 2 new line characters

-> The first line starts with anything but a tag(including empty line)
    New tag is added followed by 2 new line characters.

All of these are sure to happen there is one strange behavior as well:
   Once there has been a case of adding a new tag with 2 new lines, from the next time it always does the same thing no matter which of the above cases it has

[Nimit Shah (nimit-svnit)]

I haven't checked what happens on removing a tag and then adding a new tag. I'll check that next