Guestfs unmounting need be better + configurable

Bug #1050645 reported by Joshua Harlow
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Joshua Harlow

Bug Description

Previously (bug 1013689) there is a little shell script at the end of guestfs.py that attempts to wait 10 seconds for the guestfs process to 'die'. When that does not occur a process execution error gets raised which raises a useless error message. We are still seeing that issue with the following:

$ guestmount --version
guestmount 1.16.19rhel=6,release=1.el6

It might be nice to make that 10s configurable in the future + better logging??

Changed in nova:
assignee: nobody → Joshua Harlow (harlowja)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12998

Joshua Harlow (harlowja)
description: updated
Revision history for this message
Dan Prince (dan-prince) wrote :

Joshua,

I think fixing the error message is probably fine now (for RC1). Would you mind filing a separate bug that deals with making a possible configuration setting.

Changed in nova:
importance: Undecided → Medium
milestone: none → folsom-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/12998
Committed: http://github.com/openstack/nova/commit/b107450cf9e89c5d93b989371b3a5f66810dbf9f
Submitter: Jenkins
Branch: master

commit b107450cf9e89c5d93b989371b3a5f66810dbf9f
Author: Joshua Harlow <email address hidden>
Date: Thu Sep 13 16:41:53 2012 -0700

    Add more useful logging around the unmount fail case.

    Raise a better message with a more useful message
    rather than raising a process execution error, which
    although useful is not especially meaningful.

    Bug 1050645

    Change-Id: Id9817de26fdb16f8fce17ebd093a9550e63be19c

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.