Dashes not allowed in XML-RPC method names; also, RPC::XML::Function is dead

[Lebbeous Fogle-Weekley]

Affecting all versions of Evergreen.

Credit to Michael Smith at Equinox Software for figuring this out the hard way.

I don't know about other client libaries, but recent versions of Perl's RPC::XML actually validate method names now, meaning that clients with too new a version of RPC::XML won't be able to talk to Evergreen via XML-RPC anymore.

Solutions for new versions of Evergreen aren't that hard to imagine, but it's a little bit less clear what to do about old versions of Evergreen with new XML-RPC clients.

To be clear, RPC::XML is right to be stricter, and our method names have been incompatible with XML-RPC spec the whole time. :-/

16:00 < senator> hey fun (new?) wrinkle to the relationship between RPC::XML
                 and evergreen as the former has new releases:
16:01 < senator> somewhere between 0.73 and 0.77, the author of RPC::XML made
                 his code a little stricter about sanitizing the methodname, at
                 least in the client request code if not elsewhere.
16:01 < senator> turns out that - is an invalid character for a method name in
                 the XML-RPC spec
16:01 < senator> and every single evergreen method has a - in the name
16:02 < senator> anybody already know this and thought about it before i take
                 it to LP?
16:02 < eeevil> *groan*
16:03 * eeevil has flashbacks to The Great JSON Comment Purging Of Ought-Six
16:03 < senator> heh
16:05 < gmcharlt> senator: all hail open_ils.auth_complete !

[Lebbeous Fogle-Weekley (lebbeous)]

Solutions should cover bug 1038335 at the same time.

[Lebbeous Fogle-Weekley (lebbeous)]

Here's a branch with two commits, the first addressing bug 1038335, the second addressing this one.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/senator/xmlrpc-fixes

[Jason Stephenson (jstephenson)]

Signed off with an additional commit to remove unneeded and erroring reference to RPC::XML::Method.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/dyrcona/xmlrpc-fixes

[Dan Scott (denials)]

Merge conflicts fixed for master and rel_2_3, and committed and backported all the way back to rel_2_2. Thanks everyone.