gearman_worker_st no longer visible from gearman_job_st

[Herman J. Radtke III]

Existing pecl/gearman code:
        obj->ret= gearman_job_send_data(obj->job, data, data_len);
        if (obj->ret != GEARMAN_SUCCESS && obj->ret != GEARMAN_IO_WAIT) {
                php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s",
                        gearman_worker_error(obj->job->worker));
                RETURN_FALSE;
        }

Now that the gearman_worker_st is private, I need a function to report the error. Something like gearman_job_error().

[Brian Aker (brianaker)]

I am going to backport this to 0.39 in order to make it easy for clients to go with either the 1.0 or 1.2 branch.

[Herman J. Radtke III (hermanradtke)]

Brian,

Is there a blog post or something that explains the difference between the 1.0 and the 1.2 branch?

[Brian Aker (brianaker)]

Hi,

I believe I made one to the list.

Let me update the description on Launchpad.

Cheers,
 -Brian

On Sep 15, 2012, at 6:16 PM, Herman J. Radtke III <email address hidden> wrote:

> Brian,
>
> Is there a blog post or something that explains the difference between
> the 1.0 and the 1.2 branch?
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1050507
>
> Title:
> gearman_worker_st no longer visible from gearman_job_st
>
> Status in Gearman Server and Client Libraries:
> In Progress
>
> Bug description:
> Existing pecl/gearman code:
> obj->ret= gearman_job_send_data(obj->job, data, data_len);
> if (obj->ret != GEARMAN_SUCCESS && obj->ret != GEARMAN_IO_WAIT) {
> php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s",
> gearman_worker_error(obj->job->worker));
> RETURN_FALSE;
> }
>
>
> Now that the gearman_worker_st is private, I need a function to report the error. Something like gearman_job_error().
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/gearmand/+bug/1050507/+subscriptions

[Brian Aker (brianaker)]

Please tell me if this resolves all issues (or if there is still a need for additional updates).

By putting the fix in the 1.0 tree users can continue to use the stable release knowing that when they eventually upgrade everything will be ok.

[Herman J. Radtke III (hermanradtke)]

I am unable to successfully run configure. I get an syntax error during the vcs checkout check.

Log:
bzr branch lp:gearmand/1.0 gearmand-1.0
cd gearmand-1.0/
[vagrant@localhost gearmand-1.0]$ ./config/autorun.sh
: running `/usr/bin/autoreconf --install --verbose -Wall -Werror'
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal -I m4 --install
autoreconf: configure.ac: tracing
autoreconf: running: libtoolize --copy
libtoolize: `config/ltmain.sh' is newer: use `--force' to overwrite
libtoolize: `m4/libtool.m4' is newer: use `--force' to overwrite
libtoolize: `m4/ltoptions.m4' is newer: use `--force' to overwrite
libtoolize: `m4/ltversion.m4' is newer: use `--force' to overwrite
libtoolize: `m4/lt~obsolete.m4' is newer: use `--force' to overwrite
autoreconf: running: /usr/bin/autoconf --warnings=all,error
autoreconf: running: /usr/bin/autoheader --warnings=all,error
autoreconf: running: automake --add-missing --copy --no-force --warnings=all,error
autoreconf: Leaving directory `.'
[vagrant@localhost gearmand-1.0]$ ./configure
...
checking for vcs checkout... yes
./configure: line 33710: syntax error near unexpected token `fi'
./configure: line 33710: `fi'

[Brian Aker (brianaker)]

Can you post you configure file?

What platform?

There is a build that is winding its way through the process now.

On Sep 17, 2012, at 8:50, "Herman J. Radtke III"
<email address hidden> wrote:

> I am unable to successfully run configure. I get an syntax error during
> the vcs checkout check.
>
> Log:
> bzr branch lp:gearmand/1.0 gearmand-1.0
> cd gearmand-1.0/
> [vagrant@localhost gearmand-1.0]$ ./config/autorun.sh
> : running `/usr/bin/autoreconf --install --verbose -Wall -Werror'
> autoreconf: Entering directory `.'
> autoreconf: configure.ac: not using Gettext
> autoreconf: running: aclocal -I m4 --install
> autoreconf: configure.ac: tracing
> autoreconf: running: libtoolize --copy
> libtoolize: `config/ltmain.sh' is newer: use `--force' to overwrite
> libtoolize: `m4/libtool.m4' is newer: use `--force' to overwrite
> libtoolize: `m4/ltoptions.m4' is newer: use `--force' to overwrite
> libtoolize: `m4/ltversion.m4' is newer: use `--force' to overwrite
> libtoolize: `m4/lt~obsolete.m4' is newer: use `--force' to overwrite
> autoreconf: running: /usr/bin/autoconf --warnings=all,error
> autoreconf: running: /usr/bin/autoheader --warnings=all,error
> autoreconf: running: automake --add-missing --copy --no-force --warnings=all,error
> autoreconf: Leaving directory `.'
> [vagrant@localhost gearmand-1.0]$ ./configure
> ...
> checking for vcs checkout... yes
> ./configure: line 33710: syntax error near unexpected token `fi'
> ./configure: line 33710: `fi'
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1050507
>
> Title:
> gearman_worker_st no longer visible from gearman_job_st
>
> Status in Gearman Server and Client Libraries:
> Fix Committed
>
> Bug description:
> Existing pecl/gearman code:
> obj->ret= gearman_job_send_data(obj->job, data, data_len);
> if (obj->ret != GEARMAN_SUCCESS && obj->ret != GEARMAN_IO_WAIT) {
> php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s",
> gearman_worker_error(obj->job->worker));
> RETURN_FALSE;
> }
>
>
> Now that the gearman_worker_st is private, I need a function to report the error. Something like gearman_job_error().
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/gearmand/+bug/1050507/+subscriptions

[Herman J. Radtke III (hermanradtke)]

This is on CentOS 6. Going to test some past versions now.

Here is the offending block of code:
 $as_echo "$as_me:$LINENO: result: $ac_cv_vcs_checkout" >&5
$as_echo "$ac_cv_vcs_checkout" >&6; }

    if test "$ac_cv_vcs_checkout" = yes; then

fi

[Herman J. Radtke III (hermanradtke)]

I was able to successfully compile against the gearmand-1.1.1 release.