Create Volume Snapshot with nonexistant volume Id is throwing a server Error (HTTP 500)

[Sirisha Devineni]

Description:
Create Volume Snapshot with nonexistent volume Id is throwing a server Error(HTTP 500), it is expected to raise BadRquest.

Environment:
Single node Folsom

root@ubuntu28folsom:~/launchpad_nova/nova# curl -i http://127.0.0.1:8776/v1/c77eea6f6a7a4ded95b3235794792823/snapshots -X POST -H "X-Auth-Project-Id: demo" -H "User-Agent: python-novaclient" -H "Content-Type: application/json" -H "Accept: application/json" -H "X-Auth-Token: 9c2e71ff37654159879ee20bae918c34" -d '{"snapshot": {"display_name": null, "force": false, "display_description": null, "volume_id": "47458458"}}'
HTTP/1.1 500 Internal Server Error
Via: 1.1 HYSPROXY2
Connection: Keep-Alive
Proxy-Connection: Keep-Alive
Content-Length: 128
Date: Thu, 13 Sep 2012 17:11:50 GMT
Content-Type: application/json; charset=UTF-8
X-Compute-Request-Id: req-00a3a501-b1f2-4fe3-bfac-c43769850366

{"computeFault": {"message": "The server has either erred or is incapable of performing the requested operation.", "code": 500}}root@ubuntu28folsom:~/launchpad_nova/nova#
root@ubuntu28folsom:~/launchpad_nova/nova#

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/12944

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/12944
Committed: http://github.com/openstack/nova/commit/a7a0705699662ec3a604126eec868c673cd5328e
Submitter: Jenkins
Branch: master

commit a7a0705699662ec3a604126eec868c673cd5328e
Author: Sirisha Devineni <email address hidden>
Date: Thu Sep 13 23:44:08 2012 +0530

    Raise NotFound for non-existent volume snapshot create

    When user tries to create snapshot of a non-existent volume then
    handle the VolumeNotFound exception raised during snapshot creation
    and throw it as HTTPNotFound

    Fixes bug 1050388

    Change-Id: I869ed6a29f66889636bcf92115117d407079e539