keypair information leak

[Pedro Perez]

keypairs generated by nova include the user and the name of the controller node that generated them in the comment field of the public key.

That info can be seen in any VM in the file /root/.ssh/authorized_keys in contrast in AWS the comment field is the name of the key.

Fixing this is trivial, it is only a matter of adding the "-C", keyfile parameters to utils.execute in generate_key_pair (nova/crypto.py)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/12938

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/12938
Committed: http://github.com/openstack/nova/commit/114109dbf4094ae6b6333d41c84bebf6f85c4e48
Submitter: Jenkins
Branch: master

commit 114109dbf4094ae6b6333d41c84bebf6f85c4e48
Author: Thierry Carrez <email address hidden>
Date: Thu Sep 13 14:07:02 2012 +0200

    Overload comment in generated SSH keys

    Overload comment in generated SSH keys in order not to leak information
    about the user and host that actually generated them. Patch based on a
    suggestion by Pedro Perez.

    Fixes bug 1050347.

    Change-Id: I73bbdba1f6c9e83a5e7e70564959b9d7abaa5e29