Dashboard usability issue with the VNC console. The console looks bad - Can't see the console screen properly

[Nir Magnezi]

Scenario:
=======

1. Login Openstack via Dashbaord.
2. Click project tab (example: admin) --> Intance
3. Select an instance --> Actions --> VNC Console

Result:
=====

1. See screenshot attached to this bug
2. Notice that in order to work with the console, You'll need to work with the scroll bars. the screen cannot be extanded (tested both with Firefox and Chrome)

Reproduced several times 100% reproducible

Attached logs:
vnccolsole.png

[Gabriel Hurley (gabriel-hurley)]

Hmm... this looks to be an issue with particular VNC consoles being different sizes (most of the "default" test consoles fit in the space allotted). But I've never understood why that was sized that way to begin with so it's worth revisiting.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/14997

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/14997
Committed: http://github.com/openstack/horizon/commit/68db72b95f71a9cfa9feacfda0018e32d5a673c0
Submitter: Jenkins
Branch: master

commit 68db72b95f71a9cfa9feacfda0018e32d5a673c0
Author: Nicolas Simonds <email address hidden>
Date: Mon Oct 29 13:48:19 2012 -0700

    Dynamically size the noVNC iframe, fix typos in copy

    The iframe for the noVNC console is too small for some users who
    like to use GUI on the console. Leaving the sizes off completely
    and letting the browser figure it out causes hilarity to ensue, so
    explicitly set the height and width to quasi-sensible values.

    Also, the "unavailable" error says "unavailabe" Fixed.

    Fixes Bug 1050316 ?

    Addendum:

    add an identifier to the iframe rather than using the auto-generated selector

    Change-Id: I17cfa97cdc69f4b58e18d02451da2197c663e0d3

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/16271

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/16271
Committed: http://github.com/openstack/horizon/commit/22053000b18006339a0950af430d5bc66fc85b95
Submitter: Jenkins
Branch: master

commit 22053000b18006339a0950af430d5bc66fc85b95
Author: Nicolas Simonds <email address hidden>
Date: Thu Nov 15 15:47:28 2012 -0800

    use addHorizonLoadEvent() method instead of $(document).ready()

    These pages load all the scripts at the end, which means jQuery
    isn't loaded yet, which means there is no $ variable, which means
    the page throws errors when attempting to resize the iframe. Oops.

    There's a special method defined for doing what is being tried here,
    called addHorizonLoadEvent(), so use it instead. Confirmed working
    correctly in DevStack.

    Fixes Bug 1050316

    Change-Id: Ia6a90485acc2454ff0320abcd51860423282a659

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/23922

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23922
Committed: http://github.com/openstack/horizon/commit/1315b720052d5549d0c4916725392f8a779cf0b2
Submitter: Jenkins
Branch: stable/folsom

commit 1315b720052d5549d0c4916725392f8a779cf0b2
Author: Nicolas Simonds <email address hidden>
Date: Mon Oct 29 13:48:19 2012 -0700

    Dynamically size the noVNC iframe, fix typos in copy

    The iframe for the noVNC console is too small for some users who
    like to use GUI on the console. Leaving the sizes off completely
    and letting the browser figure it out causes hilarity to ensue, so
    explicitly set the height and width to quasi-sensible values.

    Also, the "unavailable" error says "unavailabe" Fixed.

    Fixes Bug 1050316

    Addendum:

    add an identifier to the iframe rather than using the auto-generated selector

    Cherry-picked and squashed from grizzly commits: 68db72b95f and a37779c47d

    Change-Id: I17cfa97cdc69f4b58e18d02451da2197c663e0d3