Inconsistent license in dispatcher.py

[Marc Tardif]

[Impact]

The dispatcher.py in Precise was copied from the launchpad-results project but the license was not updated to be consistent with the rest of Checkbox. The original dispatcher.py license was AGPLv3, while the rest of checkbox is GPLv3. Since both projects are authored by Canonical, it's fine to change the license.

Other than the consistency issue, this may hinder Ubuntu adoption in organizations that prefer not to use AGPL-licensed software. Also since there's no functional change, this change should present very low risk.

The license change was done in development in rev 1463:
  http://bazaar.launchpad.net/~checkbox-dev/checkbox/trunk/revision/1463

[Test case]
$ head /usr/share/pyshared/checkbox/dispatcher.py

Expected result:
- GPLv3 header like the rest of checkbox files (contrast with head /usr/share/pyshared/checkbox/application.py)

Actual result:
# Copyright 2010-2011 Canonical Ltd. This software is licensed under the
# GNU Affero General Public License version 3 (see the file LICENSE).

[Regression potential]
There is zero potential for a technical regression since the change does not affect the code's functionality.

[Clint Byrum (clint-fewbar)]

Hello Marc, or anyone else affected,

Accepted checkbox into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/checkbox/0.13.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Daniel Manrique (roadmr)]

This is an easy one to verify :)

$ apt-cache policy checkbox
checkbox:
  Installed: 0.13.8
  Candidate: 0.13.8
  Version table:
 *** 0.13.8 0
        500 http://us.archive.ubuntu.com/ubuntu/ precise-proposed/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu/ precise-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     0.13.7 0
        500 http://us.archive.ubuntu.com/ubuntu/ precise/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu/ precise/main amd64 Packages

With checkbox 0.13.8 installed...

$ head /usr/share/pyshared/checkbox/dispatcher.py
#
# This file is part of Checkbox.
#
# Copyright 2010-12 Canonical Ltd.
#
# Checkbox is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#

so it's now GPLv3 as required by the fix.

Thanks!

[Steve Langasek (vorlon)]

Hello Marc, or anyone else affected,

Accepted checkbox into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/checkbox/0.13.9 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Daniel Manrique (roadmr)]

Easy one to verify, with checkbox 0.13.9 installed:

$ head /usr/share/pyshared/checkbox/dispatcher.py
#
# This file is part of Checkbox.
#
# Copyright 2010-12 Canonical Ltd.
#
# Checkbox is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#

marking verification-done.

[Adam Conrad (adconrad)]

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package checkbox - 0.13.9

---------------
checkbox (0.13.9) precise-proposed; urgency=low

  * Updated fix for bug #1026614 which was missing some code.
  * Removed bad fix for bug 990133.

checkbox (0.13.8) precise-proposed; urgency=low

  * New upstream release (LP: #1061198)

  [Marc Tardif]
  * checkbox/dispatcher.py: Updated license to GPLv3 to be consistent with
    rest of Checkbox files (LP: #1049881)

  [Sylvain Pineau]
  * qt/frontend/qtfront.ui: Fixed the test purpose widget size to allow two
    lines of description (LP: #1032255)
  * scripts/camera_test, jobs/camera.txt.in: Added a 10s timeout to the camera
    still test (LP: #990133)

  [Daniel Manrique]
  * jobs/audio.txt.in: replaced gconfaudiosink by autoaudiosink (LP: #978895)
  * Instruct Chromium browser to accept file:// URLs so it can correctly
    open the checkbox submission.xml report (LP: #1026614)
  * scripts/network_check: InvalidURL exception is caught and handled more
    cleanly (LP: #751701)
  * Set the correct user (root) for fwts-wakealarm test (LP: #1004102)
  * Set correct user (root) for usb/storage-preinserted, so it works correctly
    on servers (LP: #1004131)

  [Nathan Williams]
  * scripts/network_check: Fixed exception handling in the absence of zenity
    (LP: #988260)
 -- Daniel Manrique <email address hidden> Tue, 20 Nov 2012 16:31:02 -0500