FFe: Un-blacklist and merge sensors-applet 3.0.0-0.2 (universe) from Debian testing (main)

[Daniel Gimpelevich]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 affects ubuntu
 status new
 importance wishlist
 subscribe ubuntu-release
 done

Please sync sensors-applet 3.0.0-0.2 (universe) from Debian testing (main)

Explanation of FeatureFreeze exception:
This was deleted from oneiric prior to release because the Debian package based on gtk3 instead of gtk2 was not yet ready. There is no longer any reason to keep it out. Please merge and prepare a diff on top of the Debian version, to include: https://launchpad.net/ubuntu/+source/sensors-applet/2.2.7-3ubuntu1 (LP: #880364)

All changelog entries:

sensors-applet (3.0.0-0.2) unstable; urgency=low

  * Non-maintainer upload.
  * Fix "FTBFS: Could not parse DTD
    http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-
    1.0/scrollkeeper-omf.dtd": add patch to validate XML against local DTD,
    build-depend on scrollkeeper for that.
    (Closes: #652222)

 -- gregor herrmann <email address hidden> Tue, 14 Feb 2012 19:05:45 +0100

sensors-applet (3.0.0-0.1) unstable; urgency=low

  * Non-maintainer upload.
  * New upstream release, with support for GNOME3 Panel (closes: #638099).
  * Drop link-to-libdl and libnotify_0.7_api_change patches, applied
    upstream.
  * Drop dh_autoreconf and all bootstrap friends from Build-Depends and
    Build-Conflicts, not needed anymore.
  * Update Build-Depends for the GTK+3 port, as per configure.ac.
  * Drop .a and .la files (closes: #633257).
  * Build-Depend on libsensors4 for kfreebsd again, as the package is now
  * available on that architecture.
  * Avoid hardcoding architecture names for libatamart-dev, and drop it
    entirely for libsensors4, as all architectures should be supported,
    even if the Hurd isn't available yet (closes: #634515).
  * As libsensors-applet-plugin hasn't bumped its sonames but has at least
    got an ABI break (due to the switch to GTK+3), and given there are no
    external rdepends, avoid a library rename by bumping its shlibs and
    adding Breaks: sensor-applets (<< 3.0.0).
  * Change install path for the applet binary, and remove obsolete dirs.
  * Tighten sensors-applet dependency on libsensors-applet-plugin to
    (= ${binary:Version}), just in case.

 -- Jordi Mallach <email address hidden> Sat, 05 Nov 2011 14:53:12 +0100

sensors-applet (2.2.7-3.1) unstable; urgency=low

  * Non-maintainer upload.
  * Fix compatibility with libnotify0.7. Patch courtesy of Steve Langasek.
    (Closes: #630301)

 -- Jérémy Bobbio <email address hidden> Wed, 03 Aug 2011 14:16:58 +0200

sensors-applet (2.2.7-3) unstable; urgency=low

  * Use dh-autoreconf to regenerate build system at build time.
  * Update to debhelper compat level 8; bump build-dependency accordingly.
  * debian/*.install: remove debian/tmp prefix that has not been necessary
    since debhelper 7.

 -- Sam Morris <email address hidden> Sat, 26 Mar 2011 14:08:11 +0000

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAlBPltsACgkQO/Dos2Fb9DSSMQCfTCetO7q5Rpn5R+X80221brGh
UZIAoI8BRrem9Oe6N49+W4cktvpxIMqX
=KDpV
-----END PGP SIGNATURE-----

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Stefano Rivera (stefanor)]

Assuming someone has tested this, and it works, it's fine by me. Syncs are easy for archive-admins to review, FFe granted.

This will need to be un-blacklisted, too.

[Stefano Rivera (stefanor)]

Oops, this was blocking on needing the Ubuntu delta to be re-applied. The FFe stands, as long as this can be done within a week or two, though.

[Colin Watson (cjwatson)]

In the meantime, I've at least unblacklisted it.

[Fabrice Coutadeur (fabricesp)]

Nothing to sponsor: removing Ubuntu Sponsors from the bug report.

Please prepare the diff and subscribe again sponsors.

Thanks,

Fabrice

[Darxus (darxus)]

I don't suppose anybody has any idea if a diff is actually currently required from Debian's version? The patches in the last Ubuntu package, for Natty, look pretty minor.

[Daniel Gimpelevich (daniel-gimpelevich)]

Looking only at the top changelog entry in the last Ubuntu package, I'd definitely vote for the diff, at the very least because lm-sensors can't talk to the nVidia binary driver.

[Darxus (darxus)]

Created a ppa, without the previous differences applied: https://launchpad.net/~darxus/+archive/sensors-applet/
List of all the commands I executed to do it are in the description.

Daniel, looks like the changes you're talking about are:

1) Add build-depends (in debian/control):
nvidia-settings (>= 173.14.09-1ubuntu2) [amd64 i386],
(Does that version need to be changed?)

2) In debian/rules:
# enable nvidia support
confflags += --with-nvidia=yes

I don't suppose anybody has a the Debian packaging for v2.2.7-2 (without Ubuntu modifications) that we could actually do a diff of?

It looks (from the changelog) like Debian was planning on splitting the nvidia support out to a separate sensors-applet-nvidia package, disabled the nvidia stuff in this one, and then never created the nvidia package?

So an import without a diff should work, but not support nvidia, right?

[Darxus (darxus)]

There's also this, in sensors-applet/Makefile.am:

-LIBS = $(GLIB_LIBS) $(GTK_LIBS) $(GNOME_LIBS) $(CAIRO_LIBS) $(LIBNOTIFY_LIBS)
+LIBS = -ldl $(GLIB_LIBS) $(GTK_LIBS) $(GNOME_LIBS) $(CAIRO_LIBS) $(LIBNOTIFY_LIBS)

Not sure how / if that's related. But looking over a debdiff from sensors-applet_3.0.0-0.2.dsc to sensors-applet_2.2.7-2ubuntu2.dsc, I think these three chunks are all that was changed in the debian version.

[Daniel Gimpelevich (daniel-gimpelevich)]

I think you meant v2.2.7-3, not v2.2.7-2, and here it is:
https://merges.ubuntu.com/s/sensors-applet/

[Darxus (darxus)]

No, I meant v2.2.7-2, because that's what the latest released ubuntu package I see is based on. But that's closer than 3.0.0-0, thanks.

The -ldl was not a delta from Debian. There are a few other chunks that are, I believe, just changes in the location of line breaks in pop-up messages. I'm thinking they're not worth keeping. For example:

 #: ../sensors-applet/sensors-applet.c:301
-"Si è verificato un errore nel tentativo di salvare la configurazione corrente del sensore. "
+"Si è verificato un errore nel tentativo di salvare la configurazione "
+"corrente del sensore. "

[Darxus (darxus)]

Debdiff attached. Contains, I believe, all the differences from Debian in the last package, minus some whitespace changes in pop-ups. Not tested. Uploaded to PPA, still building: https://launchpad.net/~darxus/+archive/sensors-applet/

[Daniel Gimpelevich (daniel-gimpelevich)]

As was stated in the bug description, the latest released Ubuntu package was based on v2.2.7-3, not v2.2.7-2, and the debdiffs for that are also at that URL.

[Darxus (darxus)]

Looks like v2.2.7-3 was an unreleased package, that failed to build.

[Darxus (darxus)]

Tested successfully from PPA built from previously attached debdiff. Re-subscribing Ubuntu Sponsors.

[Darxus (darxus)]

Added untested Precise and Oneiric packages to the PPA (covering remaining releases without an official package). Precise is built but not tested. Oneiric has not yet built.

[Darxus (darxus)]

Oneiric package built and tested. I expect the Precise packages to work, but don't plan to test them.

Nice to have this back.

[Norbert (nrbrtx)]

Thank you, Darxus!
Precise package works, all sensors are visible (udisks, libsensors, hddtemp).

[Daniel Gimpelevich (daniel-gimpelevich)]

Seems to work fine on oneiric, except that it doesn't recognize the C locale nor en_US.UTF-8, and the temps for hddtemp and udisks disagree wildly for the same disk.

[Fabrice Coutadeur (fabricesp)]

@Darxus,

Just FYI, you can find the original diff at https://patches.ubuntu.com/s/sensors-applet/
Your diff seems ok: i'll build and test the package locally.

Thanks,

Fabrice

[Fabrice Coutadeur (fabricesp)]

Some comments:
- version should be ubunt1
- you should run update-maintainer

I lost my key and I'm not able to generate a new one in Quantal, so I can't upload it right now. Sorry.
Setting back to Triaged so that another sponsor can upload it.

Fabrice

[Darxus (darxus)]

Fabrice, thanks.
Changed version to 3.0.0-0.2ubuntu1 (that's what you meant, right?)
Ran update-maintainer, which changed the maintainer to Ubuntu Developers.
Debdiff attached.

[Daniel Gimpelevich (daniel-gimpelevich)]

I hope you fixed the locales first…

[Darxus (darxus)]

Daniel: I have done nothing with locales at any point in this process. Is it an upstream problem?

I'm not even sure how locales are relevant.

[Daniel Gimpelevich (daniel-gimpelevich)]

It does not recognize the "C" locale, nor "en_US.UTF-8" but only "en" which is a problem, because Ubuntu requires that "en" be dead last in the order of preference. Oddly, this seems to affect the applet's listing in gnome-panel's list of applets to choose from, but not in the applet's own preferences windows. I have not examined exactly where in the package the cause of the problem is.

[Darxus (darxus)]

Daniel: Do you have any reason to believe this locale issue is not an upstream problem?

It seems likely that it is upstream. And 39 days after feature freeze, 17 days before release, seems like a really bad time to worry about it here.

[Daniel Gimpelevich (daniel-gimpelevich)]

For the third time: I have not examined exactly where in the package the cause of the problem is.

[Colin Watson (cjwatson)]

Unsubscribing ubuntu-archive; we did our part of this way back in comment #4. Feel free to resubscribe us if there's some other action for us to take.

[Darxus (darxus)]

Ubuntu Sponsors? Anybody (with a Quantal key) out there?

[Fabrice Coutadeur (fabricesp)]

Hi,

I checked and it seems to be working here with a locale set to LANG=en_US.UTF-8.

I'll upload it in Quantal (I have been able to generate a new key), and if, once upgraded to quantal, you still have the problem, please open a new bug report.

Thanks,

Fabrice

[Daniel Gimpelevich (daniel-gimpelevich)]

The issue is with the LANGUAGE variable, not LANG. It takes a lower priority language over "en_US" or "C" because it uses "en" which Ubuntu forces to be dead last in priority.

[Fabrice Coutadeur (fabricesp)]

uploaded: waiting in New for approval.

I just updated the dependency list to get rid of trailling ;

Thanks for your work,

Fabrice

[Darxus (darxus)]

Thanks Fabrice.

[Micah Gersten (micahg)]

Unsubscribing ubuntu-sponsors since there's nothing left to do

[Darxus (darxus)]

It's been a few days, and this package still doesn't appear to be in the archives. What needs to be done?

[Adam Conrad (adconrad)]

Reviewed and accepted.

[Norbert (nrbrtx)]

Waiting for Precise and Natty packages.

[Stefano Rivera (stefanor)]

If you want it in precise and natty, please request backports.

https://wiki.ubuntu.com/UbuntuBackports

[Norbert (nrbrtx)]

OK, filed a bug in bugreports - https://bugs.launchpad.net/precise-backports/+bug/1063665.
But guys, Precise is LTS, it must have sensors-applet. Darxus has prepared such package, I tested it.

[Darxus (darxus)]

Woo, it made it into quantal: http://packages.ubuntu.com/quantal/sensors-applet

If anybody else was curious what happens after something gets uploaded to "New":
https://launchpad.net/ubuntu/quantal/+queue
https://wiki.ubuntu.com/ArchiveAdministration

Norbert: "Must" is some pretty strong language for somebody expecting something for free without contributing any effort. I find it annoying, and I think you might have better results with more polite language. (And I basically agree with you.)

[Norbert (nrbrtx)]

I'm sorry, Darxus.
English is not my native language, I'll try to speak/write more kindly.

And thank you for your packages.

[Norbert (nrbrtx)]

There is still no sensors-applet package in Precise.

[Norbert (nrbrtx)]

12.04.3 released. Still no sensors-applet in Ubuntu repositories.

[Norbert (nrbrtx)]

12.04.4 released. Still no sensors-applet in Ubuntu repositories.