quantum floatingip-show <anything> show a result

Bug #1048088 reported by dan wendlandt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
dan wendlandt
python-neutronclient
Fix Released
Undecided
dan wendlandt

Bug Description

instead of telling you that no floating IP with that ID exists, it will search for a floating ip with that "name". Since floating IPs do not have names, quantum ignores that filter param and returns all floating IPs. If there is only one floating ip defined, the cli thinks it has a match and shows the result:

nicira@com-dev:~/devstack$ quantum floatingip-show foo
+---------------------+--------------------------------------+
| Field | Value |
+---------------------+--------------------------------------+
| fixed_ip_address | 10.0.0.3 |
| floating_ip_address | 172.24.4.227 |
| floating_network_id | 3cef3c05-35bb-40cd-a07c-5c31ade595f6 |
| id | 35b666ae-b3a9-4807-b930-3a9e53645d9e |
| port_id | ea6af46f-2ce5-40e0-9a92-1938920b7fc4 |
| router_id | 7e88f87a-243d-4d77-84be-66bb08027037 |
| tenant_id | efaea5f7466340afb0b3ab063c10d139 |
+---------------------+--------------------------------------+

dan wendlandt (danwent)
Changed in quantum:
status: New → In Progress
importance: Undecided → High
assignee: nobody → dan wendlandt (danwent)
milestone: none → folsom-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-quantumclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12663

Changed in python-quantumclient:
assignee: nobody → dan wendlandt (danwent)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-quantumclient (master)

Reviewed: https://review.openstack.org/12663
Committed: http://github.com/openstack/python-quantumclient/commit/75fcafbbc6872be61dab3cbdd3c9f63dec3cf09c
Submitter: Jenkins
Branch: master

commit 75fcafbbc6872be61dab3cbdd3c9f63dec3cf09c
Author: Dan Wendlandt <email address hidden>
Date: Sun Sep 9 09:14:33 2012 -0700

    prevent floatingip-show and floatingip-delete from querying by "name"

    bug 1048088

    floating IPs do not have names, but the show and delete commands
    inherited logic that implied that they did, leading to very odd results
    that would result is "floating-ip show X" return a result even if X
    was not a valid UUID for any floating IP.

    Change-Id: I5939a2a28ae4abf94d44fadb75a657fe706f1295

Changed in python-quantumclient:
status: In Progress → Fix Committed
dan wendlandt (danwent)
Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-rc1 → 2012.2
Changed in python-quantumclient:
milestone: none → 2.1
Akihiro Motoki (amotoki)
Changed in python-quantumclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.