test_dhcp_agent uses non-existant assert_called

Bug #1047569 reported by Mark McClain
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Mark McClain

Bug Description

Some tests in test_dhcp_agent.py use a non-existent assert_called method. The bogus method was being called on a mock, so the error masked.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12594

Changed in quantum:
assignee: nobody → Mark McClain (markmcclain)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/12594
Committed: http://github.com/openstack/quantum/commit/82d38c0ecd915bd7c4f5d4790253e6cc18858753
Submitter: Jenkins
Branch: master

commit 82d38c0ecd915bd7c4f5d4790253e6cc18858753
Author: Mark McClain <email address hidden>
Date: Fri Sep 7 14:52:12 2012 -0400

    remove incorrect mock assert_called in unit tests

    fixes bug 1047569

    The unit tests were calling a nonexistent assert_called() on the
    mocks. This patch fixes the problem by using the correct assert for
    checking that the mocked method was invoked.

    Note: This patch does not fix the error in test_call_driver() because a
    separate bug fix revises the test.

    Change-Id: Ie62e2e64f314f9ba34761e63cd5d0d6e44c5d094

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
milestone: none → folsom-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.