L3 support of Ryu plugin is broken

Bug #1047230 reported by Yoshihiro Kaneko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Yoshihiro Kaneko

Bug Description

75e2dfffaf02dd8f1b85b510e58d2f3719d97f19 breaks L3 support of Ryu plugin.

diff --git a/quantum/plugins/ryu/ryu_quantum_plugin.py b/quantum/plugins/ryu/ryu
_quantum_plugin.py
index 2359100..6210708 100644
--- a/quantum/plugins/ryu/ryu_quantum_plugin.py
+++ b/quantum/plugins/ryu/ryu_quantum_plugin.py
@@ -41,7 +41,7 @@ LOG = logging.getLogger(__name__)
 class RyuQuantumPluginV2(db_base_plugin_v2.QuantumDbPluginV2,
                          l3_db.L3_NAT_db_mixin):

- supported_extension_aliases = ["os-quantum-router"]
+ supported_extension_aliases = ["router"]

     def __init__(self, configfile=None):
         options = {"sql_connection": cfg.CONF.DATABASE.sql_connection}

Revision history for this message
dan wendlandt (danwent) wrote :

its actually more than this. you'll also need to update several methods. Take a look at TestL3NatPlugin in quantum/tests/unit/test_l3_plugin.py . This shows the methods that need to be updated. Its more complex now, as we had to add the router:external attribute to a network.

dan wendlandt (danwent)
Changed in quantum:
milestone: none → folsom-rc1
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Yoshihiro Kaneko (ykaneko0929)
Revision history for this message
Yoshihiro Kaneko (ykaneko0929) wrote :

Understood. I'll work on it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12631

Changed in quantum:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/12631
Committed: http://github.com/openstack/quantum/commit/11fb7b4c910e499a396bb37627a5337990f1c015
Submitter: Jenkins
Branch: master

commit 11fb7b4c910e499a396bb37627a5337990f1c015
Author: Yoshihiro Kaneko <email address hidden>
Date: Sat Sep 8 18:15:04 2012 +0900

    Fix broken L3 support of Ryu plugin

    Fixes bug 1047230

    This patch adds support for the router:external attribute of a network
    to Ryu plugin.

    Change-Id: I135fe0a4e90fe049cabbaa1b87e9294ec0613530

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.