deleting volume in 'error' state fails

[Dan Prince]

I'm seeing the following exceptions when trying to delete volumes in 'error' state:

2012-09-05 14:43:52 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/cinder/openstack/common/rpc/amqp.py", line 275, in _process_data
2012-09-05 14:43:52 TRACE cinder.openstack.common.rpc.amqp rval = self.proxy.dispatch(ctxt, version, method, **args)
2012-09-05 14:43:52 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/cinder/openstack/common/rpc/dispatcher.py", line 145, in dispatch
2012-09-05 14:43:52 TRACE cinder.openstack.common.rpc.amqp return getattr(proxyobj, method)(ctxt, **kwargs)
2012-09-05 14:43:52 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/cinder/volume/manager.py", line 196, in delete_volume
2012-09-05 14:43:52 TRACE cinder.openstack.common.rpc.amqp {'status': 'error_deleting'})
2012-09-05 14:43:52 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib64/python2.7/contextlib.py", line 24, in __exit__
2012-09-05 14:43:52 TRACE cinder.openstack.common.rpc.amqp self.gen.next()
2012-09-05 14:43:52 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/cinder/volume/manager.py", line 183, in delete_volume
2012-09-05 14:43:52 TRACE cinder.openstack.common.rpc.amqp self.driver.remove_export(context, volume_ref)
2012-09-05 14:43:52 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/cinder/volume/driver.py", line 374, in remove_export
2012-09-05 14:43:52 TRACE cinder.openstack.common.rpc.amqp location = volume['provider_location'].split(' ')
2012-09-05 14:43:52 TRACE cinder.openstack.common.rpc.amqp AttributeError: 'NoneType' object has no attribute 'split'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/12541

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/12541
Committed: http://github.com/openstack/cinder/commit/42cfb8fbb29577e1a0ab98ec7d8614c270f241ae
Submitter: Jenkins
Branch: master

commit 42cfb8fbb29577e1a0ab98ec7d8614c270f241ae
Author: Dan Prince <email address hidden>
Date: Thu Sep 6 22:52:35 2012 -0400

    Handle missing 'provider_location' in rm_export.

    Updates the remove_export function in the ISCSIDriver so that
    it handles the case where provider_location isn't set on
    a volume. This can occur if a volume is created but not exported.

    This was a regression from a previous commit
    (9785963c841aff5ea1c159da81f93c2bf62c70c6) which changed the way iscsi
    targets are created/deleted.

    Fixes LP Bug #1046484.

    Change-Id: Ie762b092dd2a84fe4f3b72c46c03a97ae67c53b7

[Thierry Carrez (ttx)]

Anything left to do in Nova ?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/12579

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/12579
Committed: http://github.com/openstack/nova/commit/ff3b994f12edf28d187bb1987aa7094b7897b015
Submitter: Jenkins
Branch: master

commit ff3b994f12edf28d187bb1987aa7094b7897b015
Author: Dan Prince <email address hidden>
Date: Fri Sep 7 11:52:03 2012 -0400

    Handle missing 'provider_location' in rm_export.

    Updates the remove_export function in the ISCSIDriver so that
    it handles the case where provider_location isn't set on
    a volume. This can occur if a volume is created but not exported.

    This was a regression from a previous commit
    (66f6a9edce3ccd624aba5d2a6bf3362901ed57f7) which changed the way
    iscsi targets are created/deleted.

    With this commit the Nova Smoke Test volume tests should once
    again pass.

    Fixes LP Bug #1046484.

    Change-Id: I4539d73691a058d8fdc6c864dee06c0d4e4813f7