add_router_interface should check ip overwrapping

Bug #1046061 reported by Nachi Ueno
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Hisaharu Ishii

Bug Description

Duplication of subnet is checked but duplication of ip cider is not checked.

dan wendlandt (danwent)
Changed in quantum:
milestone: none → folsom-rc1
assignee: nobody → Nachi Ueno (nati-ueno)
importance: Undecided → Medium
status: New → Confirmed
Changed in quantum:
assignee: Nachi Ueno (nati-ueno) → Hisaharu Ishii (ishii-hisaharu)
Revision history for this message
dan wendlandt (danwent) wrote :

Hi Ishii-san, thanks for fixing this. Great to have you contributing to Quantum :)

Revision history for this message
Hisaharu Ishii (ishii-hisaharu) wrote :

Hi dan-san, I'm so happy to contribute to Quantum :)
I appreciate if you would review my patch after I will put it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12537

Changed in quantum:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/12537
Committed: http://github.com/openstack/quantum/commit/5c5aadd2a1cc404acf1240f5273cce3c6d7d575a
Submitter: Jenkins
Branch: master

commit 5c5aadd2a1cc404acf1240f5273cce3c6d7d575a
Author: Hisaharu Ishii <email address hidden>
Date: Thu Sep 6 17:32:56 2012 -0700

    check subnet overlapping when adding interface to router

    Fixes bug 1046061

    Add logic in _check_for_dup_router_subnet to check subnets are not overlapped.
    Add testcase test_router_add_interface_overlapped_cidr.

    Change-Id: I71b6cce07273686cc5e4636ce640b7201ce00b32

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.