Make the info on copying text box more obvious

[Kristina Hoeppner]

The text for re-using a text box "If you edit the text of this block, it will also be changed in 1 other block(s) where it appears. Make a copy (link to make a copy)" is not obvious enough for some users and may be overlooked.

Can it be made more prominent, e.g. via a pop-up window? Is it possible to link "Make a copy" still within a pop-up or would we have to think of a different solution?

For the discussion, please see https://mahara.org/interaction/forum/topic.php?id=4827

[Kristina Hoeppner (kris-hoeppner)]

The devs said that a link can be included in a pop-up. But I think it would even be better if we had a "Yes/No" option:

If you edit the text of this block, it will also be changed in 1 other block(s) where it appears. Do you want to make a copy to edit that instead of changing it in the other 1 block(s)?
Yes (button) No (button)

[Son Nguyen (ngson2000)]

Hi Kristina;

What would you expect when users click 'No' button?
I think nothing will happen and this means the 'No' button is not necessary.

Cheers,
Son

[Aaron Wells (u-aaronw)]

I think, in the scenario Kristina described:

Yes: We would copy the Note, and use that new copy in the Text Box block.

No: We would let the Text Box block continue using the same Note

But I think a better solution to this problem is implementing the ability to make a text box *not* be shared as a note in the first place. See https://bugs.launchpad.net/mahara/+bug/1152441

On the other hand, even if we implement that, we'll still have all the existing legacy Note blocks to deal with. So this still may be worth doing.

[Kristina Hoeppner (kris-hoeppner)]

You would need the No button because it's a pop-up that you are presented with and thus you need to decide for one way.

And yes, we could turn the text box onto its head and make not copying the default, but we'd still need a decision so that users can say whether they want to make a copy or not.

[Kristina Hoeppner (kris-hoeppner)]

We only abandonded the patch as a UX designer will need to take a fresh look at it before a tech solution is proposed.

[Robert Lyon (robertl-9)]

Maybe at the very least we could scroll to the alert message on choosing the note radio button because at the moment it lives above the editor and selecting another note lives below the editor and so the alert message can be missed

[Kristina Hoeppner (kris-hoeppner)]

I suspect the only thing that wouldn't be overlooked would be a modal that would require a conscious decision, but then we'd have a modal on top of a fly-out.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9655

[Steven (stevens-q)]

TITLE: Make the info on copying text box (text block = Note block) more obvious

BUG SUMMARY: The text for re-using a Note block "If you edit the text of this block, it will also be changed in 1 other block(s) where it appears. Make a copy (link to make a copy)" is not obvious enough for some users and may be overlooked.

ACCEPTANCE CRITERIA:
Added a new feature that the user has to choose yes to
start editing copy. This will force users to interact with the
form before editing with the choice that they are editing
all copies of this content.

When selecting to use content from another note, the
form will update based on their choice. The editor will
remain open if yes has been selected. The editor will
be hidden and only the content will show if 'Yes' has
not be selected.
==============================================

Commit hash: 0df38c69d7cc8076502c717b693cf75179e22ac0
Environment tested: Master
Browser tested: Chrome
Theme used: Primary school

PRECONDITIONS:
------------------------
1) Mahara User exists (no roles)
2) Note block exists (title=Note1) on portfolio page "Version 1"

TEST STEPS:
------------------------
1) Log in as Mahara user (no roles)
2) Create a portfolio page (portfolio page "Version 2")
3) Add a Note block to the page
4) In the Note block modal, click the "Use content from another note" button
5) Select the note "Note1" as mentioned in the preconditions
6) Once a note has been selected
7) Verify that the following text is displayed: "If you edit the text of this block, it will also be changed in 0 other block(s) where it appears. Make a copy" ✔
8) Verify that the make a copy link is displayed in the above text ✔
9) Verify that the "Edit all copies of this note" yes/No toggle is displayed ✔
10) Verify that the Tiny MCE editor is hidden (user cannot edit the text) ✔

**** OPTION 1 : If the "Edit all copies of this note" yes/No toggle is set to Yes

11) Verify that the Tiny MCE editor is displayed and the note text is editable ✔
12) Edit the note text and edit the title for the note block
13) Click the save button
14) Verify that the changes have been made for the page
15) Browse to the portfolio page that contains the original note block (portfolio page "Version 1")
16) Verify that the Note text and title have the new changed made after the edit ✔

**** OPTION 2 : if the Make a copy link is clicked

11) Verify that the Tiny MCE editor is displayed and the note text is editable ✔
12) Verify that the "Edit all copies of this note" yes/No toggle is hidden ✔
13) Edit the note text and edit the title for the note block
14) Click the save button
15) Verify that the changes have been made for the page ✔
16) Browse to the portfolio page that contains the original note block (portfolio page "Version 1")
17) Verify that the original note block title and note text have not been changed ✔

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9655
Committed: https://git.mahara.org/mahara/mahara/commit/0df38c69d7cc8076502c717b693cf75179e22ac0
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0df38c69d7cc8076502c717b693cf75179e22ac0
Author: Kevin Dibble <email address hidden>
Date: Mon Mar 25 14:17:55 2019 +1300

Bug 1044878: Editing duplicated content

Added a new feature that the user has to choose yes to
start editing copy. This will force users to interact with the
form before editing with the choice that they are editing
all copies of this content.

When selecting to use content from another note, the
form will update based on their choice. The editor will
remain open if yes has been selected. The editor will
be hidden and only the content will show if 'Yes' has
not be selected.

This is a UI element only - no decision is saved to the
DB as this is an editor based decision.

behatnotneeded

Change-Id: Idb8d6736796a2350359bd59395393f6c7d742f96

[Kristina Hoeppner (kris-hoeppner)]

Kevin, I'm opening this up again as I found a couple of issues:

1. When you place a note on a page and then go to a different page and select to use the note from page 1, the message reads: "If you edit the text of this block, it will also be changed in 0 other block(s) where it appears."

Instead, it should say "If you edit the text of this block, it will also be changed in 1 other block(s) where it appears." The counting doesn't seem to work.

2. When I save the note saying that I want to use it without making a copy, and I go click the Mahara logo to navigate away from the page, I see the following error message. The same happens when I select to edit the note and when I make a copy of the note.

[WAR] 42 (artefact/lib.php:2033) Invalid argument supplied for foreach()
Call stack (most recent first):

    log_message("Invalid argument supplied for foreach()", 8, true, true, "/home/kristina/code/mahara/htdocs/artefact/lib.php", 2033) at /home/kristina/code/mahara/htdocs/lib/errors.php:520
    error(2, "Invalid argument supplied for foreach()", "/home/kristina/code/mahara/htdocs/artefact/lib.php", 2033, array(size 3)) at /home/kristina/code/mahara/htdocs/artefact/lib.php:2033
    artefact_get_owner_info(array(size 1)) at /home/kristina/code/mahara/htdocs/lib/view.php:3507
    View::build_artefactchooser_data(array(size 17), null, null) at /home/kristina/code/mahara/htdocs/view/artefactchooser.json.php:26

[WAR] 42 (lib/view.php:3507) Invalid argument supplied for foreach()
Call stack (most recent first):

    log_message("Invalid argument supplied for foreach()", 8, true, true, "/home/kristina/code/mahara/htdocs/lib/view.php", 3507) at /home/kristina/code/mahara/htdocs/lib/errors.php:520
    error(2, "Invalid argument supplied for foreach()", "/home/kristina/code/mahara/htdocs/lib/view.php", 3507, array(size 15)) at /home/kristina/code/mahara/htdocs/lib/view.php:3507
    View::build_artefactchooser_data(array(size 17), null, null) at /home/kristina/code/mahara/htdocs/view/artefactchooser.json.php:26

[Kevin Dibble (digitalskill)]

The first issue - There is no initial counting when choosing to copy the note.
I'll create a new XHR call to get this number...

The 2nd issue is a seperate bug in Mahara around notes:
It can be re-created in any version of Mahara - add a note - choose to copy the note from another - then cancel. I'll address this with this patch.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10027

[Steven (stevens-q)]

Re - issue #1
 When you place a note on a page and then go to a different page and select to use the note from page 1, the message reads: "If you edit the text of this block, it will also be changed in 0 other block(s) where it appears."

Given I have an existing note on another page and I make a new page and add a note - I am no longer seeing the text "If you edit the text of this block, it will also be changed in 1 other block(s) where it appears. Make a copy"
I think you are missing some functionality that was previously there.

As for issue #2 - I am not seeing any errors

[Kevin Dibble (digitalskill)]

I removed this message from showing functionality - as it does not appear when selecting to use a block currently. Having it show would cause an incorrect number to appear, so decided to keep current working to not have it appear.

[Kevin Dibble (digitalskill)]

I have updated the code now to show the message with the correct count to bring back the text.

[Steven (stevens-q)]

Commit hash: 62d8203a7324ed62e000c0e98b809ba710278b68
Environment tested: Master
Browser tested: Chrome
Theme used: Primary school

PRECONDITIONS:
------------------------
1) Mahara User exists (no roles)
2) Note block exists (title=Note1) on portfolio page "Version 1"

TEST STEPS:
------------------------
1) Log in as Mahara user (no roles)
2) Create a portfolio page (portfolio page "Version 2")
3) Add a Note block to the page
4) In the Note block modal, click the "Use content from another note" button
5) Select the note "Note1" as mentioned in the preconditions
6) Once a note has been selected
7) Verify that the following text is displayed: "If you edit the text of this block, it will also be changed in 0 other block(s) where it appears. Make a copy" ✔
8) Verify that the make a copy link is displayed in the above text ✔
9) Verify that the "Edit all copies of this note" yes/No toggle is displayed ✔
10) Verify that the Tiny MCE editor is hidden (user cannot edit the text) ✔

**** OPTION 1 : If the "Edit all copies of this note" yes/No toggle is set to Yes

11) Verify that the Tiny MCE editor is displayed and the note text is editable ✔
12) Edit the note text and edit the title for the note block
13) Click the save button
14) Verify that the changes have been made for the page
15) Browse to the portfolio page that contains the original note block (portfolio page "Version 1")
16) Verify that the Note text and title have the new changed made after the edit ✔

**** OPTION 2 : if the Make a copy link is clicked

11) Verify that the Tiny MCE editor is displayed and the note text is editable ✔
12) Verify that the "Edit all copies of this note" yes/No toggle is hidden ✔
13) Edit the note text and edit the title for the note block
14) Click the save button
15) Verify that the changes have been made for the page ✔
16) Browse to the portfolio page that contains the original note block (portfolio page "Version 1")
17) Verify that the original note block title and note text have not been changed ✔

ALso check

1) When you place a note on a page and then go to a different page and select to use the note from page 1, the message reads: "If you edit the text of this block, it will also be changed in 0 other block(s) where it appears." ✔
2) Verify the following when selecting "Use content from another note and selecting a note.
 a) User cannot navigate away from the note modal unless they either click save button, Remove link or click the x icon on the modal window." ✔
 b) Clicking remove link = Closes modal window and there are no changes to the page " ✔
 c) Clicking the x icon on the modal window. = Will display an alert Box with the following text "Are you sure you wish to delete this block?" and a Cancel button and OK button " ✔
  * Clicking the "OK" button will close the modal window and there are no changes to the page" ✔
  * Clicking Cancel button closes the alert box and modal window is still open " ✔

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10027
Committed: https://git.mahara.org/mahara/mahara/commit/62d8203a7324ed62e000c0e98b809ba710278b68
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 62d8203a7324ed62e000c0e98b809ba710278b68
Author: Kevin Dibble <email address hidden>
Date: Mon Mar 25 14:17:55 2019 +1300

Bug 1044878: Editing duplicated content

Added a new feature that the user has to choose yes to
start editing copy. This will force users to interact with the
form before editing with the choice that they are editing
all copies of this content.

When selecting to use content from another note, the
form will update based on their choice. The editor will
remain open if yes has been selected. The editor will
be hidden and only the content will show if 'Yes' has
not be selected.

This is a UI element only - no decision is saved to the
DB as this is an editor based decision.

behatnotneeded

Change-Id: If44522c00672b296242893f0c876e7ff37561dd2

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10733
Committed: https://git.mahara.org/mahara/mahara/commit/8da02300c6a126436f396b2afae84cce52494a98
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 8da02300c6a126436f396b2afae84cce52494a98
Author: Rangi Daymond <email address hidden>
Date: Mon Jan 27 14:08:21 2020 +1300

Bug 1860943: Behat: Update copy_note_content.feature

Refer to Bug 1044878 Make the info on copying text box more obvious.

Update Behat test copy_note_content.feature to include coverage for
creating a new note block via
a) copy note content (and create new note content that can be edited
separate to the original content)
versus
b) use existing note content (and edit the original content in all
places that it is used).

Change-Id: Ia5e94305bfbf2da96c35b9b634cd9d8788a24ddd