network_delete RPC on openvswitch agent does nothing

[Robert Kukura]

There is a TODO comment in OVSRpcCallbacks.network_delete() regarding deleting the bridge interface, but the code does nothing but log debug messages. This RPC is called on all agents when the plugin processes a delete_network() API request. With the current openvswitch agent implementation there is no bridge interface that needs to be deleted when a network is deleted. All flows, etc., should be cleaned up when the last port on the network is deleted, so there should normally be nothing to do in network_delete(). But it might be worth having the agent check to make sure no LocalVLANMapping remains in OVSQuantumAgent.local_vlan_map for the deleted network in case the plugin and agent have somehow gotten out of sync. If any do remain, calling OVSQuantumAgent.reclaim_local_vlan() should take care of cleaning up. If this check and cleanup are not worth doing, then the RPC should be removed from the plugin and agent.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/12291

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/12291
Committed: http://github.com/openstack/quantum/commit/0ff186758d6cbc4ead3e91ff361b56b5f4ab9575
Submitter: Jenkins
Branch: master

commit 0ff186758d6cbc4ead3e91ff361b56b5f4ab9575
Author: Gary Kotton <email address hidden>
Date: Sat Sep 1 03:27:14 2012 -0400

    Ensure network delete is handled by OVS agent

    Fixes bug 1044574

    The class OVSRpcCallbacks was deleted and the treatment of the RPC
    callbacks moved into OVSQuantumAgent.

    Change-Id: I1c5f5185e3f7e0f27aba6d254f2bb3b6edf6a385