UIFe: Checkbox header graphic is wrong

Bug #1044035 reported by Daniel Manrique
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
checkbox (Ubuntu)
Fix Released
High
Daniel Manrique

Bug Description

When uploading checkbox 0.14.4, an updated header graphic was left behind, due to bad handling of changed binary files. So Checkbox starts and looks like this:

http://people.canonical.com/~roadmr/header-bad.png

Simply copying the file from trunk (qt/frontend/images/checkbox-qt-head.png) into the Ubuntu tree will fix this problem.

With the correct graphic Checkbox should look like this:

http://people.canonical.com/~roadmr/header-good.png

Tags: uife

Related branches

Daniel Manrique (roadmr)
Changed in checkbox (Ubuntu):
status: New → Triaged
importance: Undecided → High
milestone: none → ubuntu-12.10-beta-1
assignee: nobody → Daniel Manrique (roadmr)
Revision history for this message
Kate Stewart (kate.stewart) wrote :

Please ensure this lands by 9/14, and that ubuntu-doc team is notified via email of the change.

summary: - Checkbox header graphic is wrong
+ UIFe: Checkbox header graphic is wrong
Changed in checkbox (Ubuntu):
milestone: ubuntu-12.10-beta-1 → ubuntu-12.10-beta-2
Revision history for this message
Daniel Manrique (roadmr) wrote :

Per UIFe procedure, here's the link to the ubuntu-doc mailing list thread:

https://lists.ubuntu.com/archives/ubuntu-doc/2012-September/016832.html

Revision history for this message
Jeremy Bícha (jbicha) wrote :

+1 from Docs.

The "good" screenshot has too much whitespace padding below the Continue button.

And I can't figure out what the first symbolic icon on the left of the header is supposed to represent.

Revision history for this message
David Planella (dpm) wrote : Re: UIFe: Checkbox header image is wrong

Al 11/09/12 15:32, En/na Daniel Manrique ha escrit:
> Hello!
>
> I'm writing again to request a UI Freeze Exception for checkbox. Currently
> checkbox in Ubuntu has a wrong header image as can be seen here:
>
> http://people.canonical.com/~roadmr/header-bad.png
>
> We'd like to replace it with this, which is present in the development version
> but got left behind during a merge due to an oversight (apologies):
>
> http://people.canonical.com/~roadmr/header-good.png
>
> This new header image works better with the default Ubuntu theme and also takes
> care of usability concerns, where testers were unsure if the "icons" on the old
> header image are clickable.
>
> No translatable strings are involved or changed; the "system testing" string on
> the right is already in the .pot file and didn't change. Also there's no change
> to checkbox's functionality.
>
> The corresponding bug report is this one:
>
> https://bugs.launchpad.net/ubuntu/+source/checkbox/+bug/1044035
>
> Thanks!
>
> - Daniel
>
>

Hi Daniel,

A couple of cycles ago I filed a bug requesting the header text to be
translatable, which was eventually fixed in Checkbox.

I now see the untranslated "System Testing" string in the header again,
even though it is translated in Launchpad. So I assume that this has
regressed and we're back to non-translatable static text (or perhaps it
is a consequence of the of this bug).

Would it not be possible to e.g. reuse the Software Center code already
has for its banners? Visually it'd be identical and the default banner's
text ("Our star apps") on the SC is fully translatable already.

Right now, the "System Testing" text says nothing to non-English
speakers, and it feels a bit out of place in a desktop that is otherwise
fully translated.

Thanks.

Cheers,
David.

[1]
https://translations.launchpad.net/ubuntu/quantal/+source/checkbox/+pots/checkbox/ca/1/+translate

--
David Planella
Ubuntu Translations Coordinator
www.ubuntu.com / www.davidplanella.wordpress.com
www.identi.ca/dplanella / www.twitter.com/dplanella

Revision history for this message
Daniel Manrique (roadmr) wrote :
Download full text (3.4 KiB)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12-09-11 10:12 AM, David Planella wrote:
> Al 11/09/12 15:32, En/na Daniel Manrique ha escrit:
>> Hello!
>>
>> I'm writing again to request a UI Freeze Exception for checkbox.
>> Currently checkbox in Ubuntu has a wrong header image as can be seen
>> here:
>>
>> http://people.canonical.com/~roadmr/header-bad.png
>>
>> We'd like to replace it with this, which is present in the development
>> version but got left behind during a merge due to an oversight
>> (apologies):
>>
>> http://people.canonical.com/~roadmr/header-good.png
>>
>> This new header image works better with the default Ubuntu theme and also
>> takes care of usability concerns, where testers were unsure if the
>> "icons" on the old header image are clickable.
>>
>> No translatable strings are involved or changed; the "system testing"
>> string on the right is already in the .pot file and didn't change. Also
>> there's no change to checkbox's functionality.
>>
>> The corresponding bug report is this one:
>>
>> https://bugs.launchpad.net/ubuntu/+source/checkbox/+bug/1044035
>>
>> Thanks!
>>
>> - Daniel
>>
>>
>
> Hi Daniel,
>
> A couple of cycles ago I filed a bug requesting the header text to be
> translatable, which was eventually fixed in Checkbox.
>
> I now see the untranslated "System Testing" string in the header again,
> even though it is translated in Launchpad. So I assume that this has
> regressed and we're back to non-translatable static text (or perhaps it is
> a consequence of the of this bug).

Hi David,

This was an oversight on my part, for which I apologize now. I was under the
impression that the old "System Testing" string had been reused for this
screen. On closer analysis based on your comments, I see that indeed a new
string has been added, this was needed because, as you can see, the frame
where the string resides is on the right side of the banner and the words
appear in separate lines.

So I need to amend my request to both -translators and -doc to state "One new
string has been added". I rebuilt the .pot file on my tree and this is the new
string:

#: ../qt/frontend/ui_qtfront.h:635
msgid ""
"System \n"
"Testing"
msgstr ""

Also based on testing with slighly longer translatons from other languages, I
reduced the font size so those strings fit.

Thanks and apologies for the last-minute changes!

> Would it not be possible to e.g. reuse the Software Center code already has
> for its banners? Visually it'd be identical and the default banner's text
> ("Our star apps") on the SC is fully translatable already.
>
> Right now, the "System Testing" text says nothing to non-English speakers,
> and it feels a bit out of place in a desktop that is otherwise fully
> translated.
>
> Thanks.
>
> Cheers, David.
>
> [1]
> https://translations.launchpad.net/ubuntu/quantal/+source/checkbox/+pots/checkbox/ca/1/+translate
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQEcBAEBAgAGBQJQT1wmAAoJELLN2o+BkKXQZdIH/RncqDODRRpsF2JfpMspsegA
RxL469LCI4vKecp/aDlKmqmi9st8HrcTBPVYn8AahBJIVOWv7X3Xq/8Ab9S6IE3K
kNqYkX4hTWN4ZHk0BWSAU5y4gZQgCs...

Read more...

Revision history for this message
Redmar (redmar) wrote :

Hi. I saw the discussion between dpm and roadmr on irc, and I want to add a request:
Please add a comment to the relevant string to indicate to translators the maximum length of the translation. This way, we know what the limit is and can try to modify our translations to fit it.

Revision history for this message
Daniel Manrique (roadmr) wrote :

Hi Redmar,

I looked at adding a comment as per your request, however it's not as simple as it seemed :( the user interface is defined in a QT .ui file, so the string is contained in an XML block like this:

<string comment="Maximum length is 14 characters per line">System
Testing</string>

This is then converted to a .h file by uic-qt4. However the comment doesn't actually get added as a "comment" to the C file, rather, it's added as a "context" to the translator method we specify:

welcomeLabel->setText(checkboxTr("System \n"
"Testing", "Maximum length is 14 characters per line"));

Since this is not an actual comment, when intltool is run in the next step, this gets completely ignored:

#: ../qt/frontend/ui_qtfront.h:635
msgid ""
"System \n"
"Testing"
msgstr ""

So apparently, as it is I don't think we can add the comment as you request :( My apologies for this. I will continue to research ways to add the comment to help translators.

Revision history for this message
David Planella (dpm) wrote :

Had a long discussion with Daniel on IRC, and as he's explaining, we haven't been able to find a solution for the comment, so we'll leave it for now.

+1 from the translations team. Thanks for making the title translatable!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package checkbox - 0.14.6

---------------
checkbox (0.14.6) quantal; urgency=low

  * New upstream release (LP: #1049130)

  * qt/frontend/images/checkbox-qt-head.png: updated header image
    (LP: #1044035)
 -- Daniel Manrique <email address hidden> Tue, 11 Sep 2012 09:47:33 -0400

Changed in checkbox (Ubuntu):
status: Triaged → Fix Released
tags: added: uife
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.