OpenStack Compute (nova)

Deprecation change broke SimpleScheduler

Bug #1041385 reported by Maru Newby
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Maru Newby
OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

The recent change to indicate that SimpleScheduler was deprecated was a bit too hasty - it broke the schedule_run_instance() method by passing self to a super()'d invocation:

https://review.openstack.org/#/c/11512/

Maru Newby (maru)
Changed in nova:
assignee: nobody → Maru Newby (maru)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11959

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/11959
Committed: http://github.com/openstack/nova/commit/44d467402d31c3ca29b4c4e3fae41aff3fca7593
Submitter: Jenkins
Branch: master

commit 44d467402d31c3ca29b4c4e3fae41aff3fca7593
Author: Maru Newby <email address hidden>
Date: Fri Aug 24 14:55:23 2012 -0700

    Fix broken SimpleScheduler.schedule_run_instance()

     * The fix for 1037829 broke SimpleScheduler by unnecessarily
       including the 'self' parameter in the invocation of the parent's
       schedule_run_instance(). This change removes the 'self' parameter.
     * Addresses bug 1041385

    Change-Id: I95b28fce9b17b6c1d9ca2f19cd83608cde8479ee

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.