Remove reference to verbose API fetch mechsnism

Bug #1040568 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Salvatore Orlando

Bug Description

Quantum API made provisions for a "verbose" loading mechanism, which allowed to load a resource together with all its subresource, similar to the 'detail' action in Quantum v1 API.

However, the base plugin and plugins deriving from it never implemented this mechanism, so it might be worth removing references to 'verbose' and avoiding possible confusion.

We will implement this mechanism in the next version of the API. It will not break backward-compatibility.

Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

The verbose feature has been actually implemented as concerns fetching data from the db, and passing the verbose parameter from the API.

However returned 'verbose' data are then destroyed by the make_<resource>_dict methods. Even if these methods are adapted to deal with nested resources, we will have then the same problems with views in the API layer.

At this stage of the development process, I would not take the risk of fixing the response behaviour. So I'd just remove support for it, with a promise of having appropriate 'verbose' behaviour in the next release of the API.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11871

Changed in quantum:
status: New → In Progress
Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

A patch is now up for review.
Looking at the patch, it is quite clear that this is a change in the plugin interface. Anyway since verbose is a keyword parameter, it should not break other plugin not in the quantum source tree.

Reintroducing the verbose attribute would require to change the plugin interface again.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/11871
Committed: http://github.com/openstack/quantum/commit/d572233045ce1cfacc45e5eba83ef44bfc9a631e
Submitter: Jenkins
Branch: master

commit d572233045ce1cfacc45e5eba83ef44bfc9a631e
Author: Salvatore Orlando <email address hidden>
Date: Fri Aug 24 06:06:06 2012 -0700

    Remove 'verbose' API capability

    Fixes bug 1040568

    Remove parsing of "verbose" query param from API layer
    Remove "verbose" fetching from db in db_base_plugin
    Remove "verbose" parameter from plugin methods

    Change-Id: I5826fd64c7d8c48f4da605f32d21d96280c4c9f2

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.