hacking.py N801/N302 doesn't set the return value to -1

Bug #1039697 reported by Joe Gordon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Joe Gordon

Bug Description

Although hacking.py N801/N802 (git commit format) lists the error, it doesn't set the return value for hacking.py to -1. This causes the error to be ignored in tox.

https://jenkins.openstack.org/job/gate-nova-pep8/8536/consoleFull

11:57:03 /home/jenkins/workspace/gate-nova-pep8$ /home/jenkins/workspace/gate-nova-pep8/.tox/pep8/bin/python tools/hacking.py --ignore=N4 --repeat --show-source --exclude=.venv,.tox,dist,doc,*openstack/common*,*lib/python*,*egg .
11:57:32 78 imports missing in this test environment
11:57:32 N801: git commit title ('Debugged bug 1038979') should provide an accurate description of the change, not just a reference to a bug or blueprint
11:57:32 ___________________________________ summary ____________________________________
11:57:32 pep8: commands succeeded

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11739

Changed in nova:
assignee: nobody → Joe Gordon (joe-gordon0)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/11739
Committed: http://github.com/openstack/nova/commit/6109970e2a5598fd32049bcd5b3fd49b332a843d
Submitter: Jenkins
Branch: master

commit 6109970e2a5598fd32049bcd5b3fd49b332a843d
Author: Joe Gordon <email address hidden>
Date: Tue Aug 21 10:00:17 2012 -0700

    Fix hacking.py git checks to propagate errors

    Now when N801 or N802 is hit tools/hacking.py will return -1.

    Fix bug 1039697

    Change-Id: I9f6950a4396ae82861e5de0e4f3ba8b482c4fdf8

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.