Exception while associating a floating ip

[Salvatore Orlando]

[Originally reported from garyk]

The l3 plugin is unable to create and associate a floating IP in the same step. Doing it in two separate steps does not cause any exception.

The following command causes the exception:
FIP2_ID=`quantum floatingip-create $PUB_NET_ID --port_id $VM2_PORT_ID | grep ' id' | awk '{ print $4 }'`

The following two command work:
FIP2_ID=`quantum floatingip-create $PUB_NET_ID | grep ' id' | awk '{ print $4 }'`
quantum floatingip-associate $FIP2_ID $VM2_PORT_ID

Traceback available at http://paste.openstack.org/show/20375/

[dan wendlandt (danwent)]

yes, I just started seeing this recently with my test scrip... I will look into it (seems like this identifies a gap I thought I had covered in my unit tests).

[dan wendlandt (danwent)]

Looks like this was the result of a miscommunication when Salvatore pitched in to help my patch across the finish line. I'm posting a review.

[dan wendlandt (danwent)]

also, this case is already covered fairly well with unit tests. An odd quirk of the bug actually let it still pass on simple testing scenarios (particularly when there were a small number of 'internal subnets', and the setup happened in a particular order).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/11695

[Salvatore Orlando (salvatore-orlando)]

Yep, I told GaryK on IRC that I introduced this bug while fixing the other bug he spotted on floating IP creation.

[dan wendlandt (danwent)]

ok, could you do me a favor and check that my review doesn't undo the fix you were adding?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/11695
Committed: http://github.com/openstack/quantum/commit/4cb85bf3fdb5f86f909bc81a538453724d64a733
Submitter: Jenkins
Branch: master

commit 4cb85bf3fdb5f86f909bc81a538453724d64a733
Author: Dan Wendlandt <email address hidden>
Date: Mon Aug 20 22:42:23 2012 -0700

    fix associating a floating IP during floating IP creation.

    bug 1038962

    also add check to make sure that floating IP's are only associated if
    the upstream router has a external network gateway to the appropriate
    external network.

    Change-Id: Ie4cb632296ce4a1cb989242eb894d73a7488cdb3

[Salvatore Orlando (salvatore-orlando)]

I checked and approved.
The check for validating at least an IP was available for setting floating_ip_address was not touched by your patch, and that was what solved the issue first found by gary