malformed server update causes: KeyError: 'server'

[Dan Prince]

Posting a malformed update PUT request to the /servers Openstack API will cause the following exception:

From the disk_config extension:

2012-08-17 19:29:20 TRACE nova.api.openstack response = gen.next()
2012-08-17 19:29:20 TRACE nova.api.openstack File "/usr/lib/python2.7/site-packages/nova/api/openstack/compute/contrib/disk_config.py", line 151, in update
2012-08-17 19:29:20 TRACE nova.api.openstack self._set_disk_config(body['server'])
2012-08-17 19:29:20 TRACE nova.api.openstack KeyError: 'server'
2012-08-17 19:29:20 TRACE nova.api.openstack

From the servers.py core update function:

2012-08-17 19:31:51 TRACE nova.api.openstack File "/usr/lib/python2.7/site-packages/nova/api/openstack/wsgi.py", line 1000, in dispatch
2012-08-17 19:31:51 TRACE nova.api.openstack return method(req=request, **action_args)
2012-08-17 19:31:51 TRACE nova.api.openstack File "/usr/lib/python2.7/site-packages/nova/api/openstack/compute/servers.py", line 823, in update
2012-08-17 19:31:51 TRACE nova.api.openstack if 'name' in body['server']:
2012-08-17 19:31:51 TRACE nova.api.openstack KeyError: 'server'
2012-08-17 19:31:51 TRACE nova.api.openstack

----

This causes an HTTP 500 exception. It should return a 422 unprocessable entity.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/11578

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/11578
Committed: http://github.com/openstack/nova/commit/1a605cccb1fe29ae6554ad5afa3110abef11d9c2
Submitter: Jenkins
Branch: master

commit 1a605cccb1fe29ae6554ad5afa3110abef11d9c2
Author: Dan Prince <email address hidden>
Date: Fri Aug 17 15:34:28 2012 -0400

    Return HTTP 422 on bad server update PUT request.

    This patch updates the /servers API and the disk config
    extension so that they properly handle incorrectly formatted
    server update/PUT requests.

    Includes a new test cause that verifies (with extensions enabled)
    that a poorly formatted PUT request to /servers returns HTTP 422
    instead of a 500.

    Also updated the previous test_create_missing_server test to use
    test.TestException instead of Exception.

    Fixes LP Bug #1038227.

    Change-Id: I6b11602790778465348647bb5825b7326d50065a