Regression in simple extra_specs matching in compute_capabilities_filter

Bug #1037503 reported by Mark McLoughlin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Mark McLoughlin

Bug Description

Before https://review.openstack.org/#/c/8089/, you could do something like:

   sudo nova-manage instance_type set_key nokvm.tiny hypervisor_type QEMU

and only compute hosts whose "hypervisor_type" was reported as "QEMU" would pass the host filter.

i.e. we did simple string matching of extra specs against host capabilities

Now, if no operator is present in extra specs, we no longer do string matching and just say that the extra spec is satisfied.

This is unintentional. The previous behaviour should be retained.

Revision history for this message
Mark McLoughlin (markmc) wrote :
Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11459

Changed in nova:
assignee: Mark McLoughlin (markmc) → Vish Ishaya (vishvananda)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/11534

Changed in nova:
assignee: Vish Ishaya (vishvananda) → Mark McLoughlin (markmc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/11459
Committed: http://github.com/openstack/nova/commit/53c40cfc18fe5c57ca724e5d7902e18fe09cc09f
Submitter: Jenkins
Branch: master

commit 53c40cfc18fe5c57ca724e5d7902e18fe09cc09f
Author: Mark McLoughlin <email address hidden>
Date: Thu Aug 16 12:02:34 2012 +0100

    Fix regression in compute_capabilities filter

    Fixes bug #1037503

    Restore the previous behaviour of matching simple strings in extra
    specs against compute node capabilities.

    Change-Id: I485e9e63f860a83f7c9c0c41d09919eabe9e66ae

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (milestone-proposed)

Reviewed: https://review.openstack.org/11534
Committed: http://github.com/openstack/nova/commit/38c55a7858c50d530cca687937d9e2f4d0478483
Submitter: Jenkins
Branch: milestone-proposed

commit 38c55a7858c50d530cca687937d9e2f4d0478483
Author: Mark McLoughlin <email address hidden>
Date: Thu Aug 16 12:02:34 2012 +0100

    Fix regression in compute_capabilities filter

    Fixes bug #1037503

    Restore the previous behaviour of matching simple strings in extra
    specs against compute node capabilities.

    Change-Id: I485e9e63f860a83f7c9c0c41d09919eabe9e66ae
    (cherry picked from commit 4ec703243415b9eb6d57bd72f2f6704a95308067)

Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.